mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd
@ 2007-04-07 16:14 Rafael J. Wysocki
  2007-04-07 21:18 ` Nigel Cunningham
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2007-04-07 16:14 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Gautham R Shenoy, LKML, Nigel Cunningham, Pavel Machek

From: Rafael J. Wysocki <rjw@sisk.pl>

Make handle_initrd() call try_to_freeze() in a suitable place instead of setting
PF_NOFREEZE for the current task.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 init/do_mounts_initrd.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6.21-rc6/init/do_mounts_initrd.c
===================================================================
--- linux-2.6.21-rc6.orig/init/do_mounts_initrd.c
+++ linux-2.6.21-rc6/init/do_mounts_initrd.c
@@ -55,11 +55,12 @@ static void __init handle_initrd(void)
 	sys_mount(".", "/", NULL, MS_MOVE, NULL);
 	sys_chroot(".");
 
-	current->flags |= PF_NOFREEZE;
 	pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD);
 	if (pid > 0) {
-		while (pid != sys_wait4(-1, NULL, 0, NULL))
+		while (pid != sys_wait4(-1, NULL, 0, NULL)) {
+			try_to_freeze();
 			yield();
+		}
 	}
 
 	/* move initrd to rootfs' /old */

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd
  2007-04-07 16:14 [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd Rafael J. Wysocki
@ 2007-04-07 21:18 ` Nigel Cunningham
  2007-04-07 21:24 ` Nigel Cunningham
  2007-04-08 12:10 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Nigel Cunningham @ 2007-04-07 21:18 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Andrew Morton, Gautham R Shenoy, LKML, Pavel Machek

Hi.

On Sat, 2007-04-07 at 18:14 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Make handle_initrd() call try_to_freeze() in a suitable place instead of setting
> PF_NOFREEZE for the current task.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  init/do_mounts_initrd.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.21-rc6/init/do_mounts_initrd.c
> ===================================================================
> --- linux-2.6.21-rc6.orig/init/do_mounts_initrd.c
> +++ linux-2.6.21-rc6/init/do_mounts_initrd.c
> @@ -55,11 +55,12 @@ static void __init handle_initrd(void)
>  	sys_mount(".", "/", NULL, MS_MOVE, NULL);
>  	sys_chroot(".");
>  
> -	current->flags |= PF_NOFREEZE;
>  	pid = kernel_thread(do_linuxrc, "/linuxrc", SIGCHLD);
>  	if (pid > 0) {
> -		while (pid != sys_wait4(-1, NULL, 0, NULL))
> +		while (pid != sys_wait4(-1, NULL, 0, NULL)) {
> +			try_to_freeze();
>  			yield();
> +		}
>  	}
>  
>  	/* move initrd to rootfs' /old */

ACK.

Regards,

Nigel


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd
  2007-04-07 16:14 [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd Rafael J. Wysocki
  2007-04-07 21:18 ` Nigel Cunningham
@ 2007-04-07 21:24 ` Nigel Cunningham
  2007-04-08 12:10 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Nigel Cunningham @ 2007-04-07 21:24 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Andrew Morton, Gautham R Shenoy, LKML, Pavel Machek

Hi again.

By the way, I'm stopping using ncunningham@linuxmail.org; could you
please change your address book to nigel at nigel dot suspend2 dot net?

Thanks!

Nigel


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd
  2007-04-07 16:14 [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd Rafael J. Wysocki
  2007-04-07 21:18 ` Nigel Cunningham
  2007-04-07 21:24 ` Nigel Cunningham
@ 2007-04-08 12:10 ` Pavel Machek
  2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2007-04-08 12:10 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Andrew Morton, Gautham R Shenoy, LKML, Nigel Cunningham

Hi!

> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Make handle_initrd() call try_to_freeze() in a suitable place instead of setting
> PF_NOFREEZE for the current task.

ACK and thanks.

							Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-04-08 12:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-04-07 16:14 [PATCH -mm] freezer: Remove PF_NOFREEZE from handle_initrd Rafael J. Wysocki
2007-04-07 21:18 ` Nigel Cunningham
2007-04-07 21:24 ` Nigel Cunningham
2007-04-08 12:10 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®