From: Richard Purdie <richard@openedhand.com>
To: David Woodhouse <dwmw2@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, torvalds@linux-foundation.org
Subject: Re: [PATCH] Add LZO1X compression support to the kernel
Date: Thu, 10 May 2007 09:53:44 +0100 [thread overview]
Message-ID: <1178787224.5828.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1178785576.28494.17.camel@pmac.infradead.org>
On Thu, 2007-05-10 at 09:26 +0100, David Woodhouse wrote:
> On Wed, 2007-05-09 at 23:21 -0700, Andrew Morton wrote:
> > Well that's attractive-looking code.
>
> It's compression code. I've never seen compression code look nice :)
>
> > Why is this needed? What code plans to use it?
>
> I'm itching to use it in JFFS2. Richard claims a 10% boot time speedup
> and 40% improvement on file read speed, with only a slight drop in the
> file compression ratio (when compared to zlib).
Right, the speed improvement is noticeable and useful. JFFS2 is the
primary use case, I've also implemented a crypto interface for it.
> > How many buffer overruns are there in it?
>
> That I'm afraid I cannot tell you.
There is a "safe" decompression function which does bounds checking so
its at least been thought about by the author. The code has been around
in userspace for a while so hopefully any issues have been ironed out
before now.
Richard
next prev parent reply other threads:[~2007-05-10 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 8:56 Richard Purdie
2007-05-02 9:35 ` Pekka Enberg
2007-05-04 18:28 ` Satyam Sharma
2007-05-10 6:21 ` Andrew Morton
2007-05-10 8:26 ` David Woodhouse
2007-05-10 8:53 ` Richard Purdie [this message]
2007-05-10 14:30 ` Jan Engelhardt
2007-05-12 11:17 ` Adrian Bunk
2007-05-12 15:17 ` Richard Purdie
2007-05-12 16:47 ` Andrew Morton
2007-05-12 20:56 ` Richard Purdie
2007-05-13 11:59 ` Markus F.X.J. Oberhumer
2007-05-10 8:49 Tomasz Chmielewski
2007-05-11 20:48 devzero
2007-05-13 13:06 ` Jindrich Makovicka
2007-05-12 10:41 devzero
2007-05-12 11:41 ` Jindrich Makovicka
2007-05-12 19:51 ` Satyam Sharma
2007-05-15 16:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178787224.5828.11.camel@localhost.localdomain \
--to=richard@openedhand.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome