From: "Satyam Sharma" <satyam.sharma@gmail.com>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Richard Purdie" <richard@openedhand.com>,
LKML <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
torvalds@osdl.org, "David Woodhouse" <dwmw2@infradead.org>
Subject: Re: [PATCH] Add LZO1X compression support to the kernel
Date: Fri, 4 May 2007 23:58:38 +0530 [thread overview]
Message-ID: <a781481a0705041128l75eb8e87l92cb55ebd21459d8@mail.gmail.com> (raw)
In-Reply-To: <84144f020705020235k3d984ccbv83910f6a6aa48f41@mail.gmail.com>
Hi Richard, Pekka,
On 5/2/07, Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> On 5/2/07, Richard Purdie <richard@openedhand.com> wrote:
> > I realise a maze of ifdefs still remain. I've already spent a lot of
> > time removing a ton of them and going much further might start to affect
> > diffability of the code - I hoping whats there is a good compromise.
>
> I really don't think this is suitable for inclusion in the kernel. Any
> reason why you don't just fork the code and clean it up properly? Sure
> it will take some more work to track the original but how hard can it
> be for ~1700 lines of code?
I'd have to agree with that. When something gets ported to the kernel
(from some userspace library, or from any other piece of software),
then it _must_ be ported completely and follow the usual kernel style.
In fact I bet you can knock off a cool couple of hundred lines of gunk
from the patch just by doing a proper port and getting rid of those
pointless typedefs, for example.
(On an unrelated note/rant, this was one of the reasons why I
absolutely hate those MODSIGN patches being maintained by Red
Hat/Fedora/etc that port the GNU MPI library to the kernel but don't
do so properly, so that it can be diffed with future GNU MP releases
for easy maintainability -- with the result that the patch ends up
containing arch-specific assembly for platforms that Linux doesn't
even run on! Good to see that at least you've taken the pains to avoid
that kind of brain damage, but a full port would be better)
Thanks,
Satyam
next prev parent reply other threads:[~2007-05-04 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 8:56 Richard Purdie
2007-05-02 9:35 ` Pekka Enberg
2007-05-04 18:28 ` Satyam Sharma [this message]
2007-05-10 6:21 ` Andrew Morton
2007-05-10 8:26 ` David Woodhouse
2007-05-10 8:53 ` Richard Purdie
2007-05-10 14:30 ` Jan Engelhardt
2007-05-12 11:17 ` Adrian Bunk
2007-05-12 15:17 ` Richard Purdie
2007-05-12 16:47 ` Andrew Morton
2007-05-12 20:56 ` Richard Purdie
2007-05-13 11:59 ` Markus F.X.J. Oberhumer
2007-05-10 8:49 Tomasz Chmielewski
2007-05-11 20:48 devzero
2007-05-13 13:06 ` Jindrich Makovicka
2007-05-12 10:41 devzero
2007-05-12 11:41 ` Jindrich Makovicka
2007-05-12 19:51 ` Satyam Sharma
2007-05-15 16:54 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a781481a0705041128l75eb8e87l92cb55ebd21459d8@mail.gmail.com \
--to=satyam.sharma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=richard@openedhand.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®