mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Pierre Ossman <drzeus@drzeus.cx>
Cc: linux-kernel@vger.kernel.org, Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: [PATCH] MMC: Flush mmc workqueue late in the boot sequence
Date: Thu, 10 May 2007 12:35:37 +0200	[thread overview]
Message-ID: <117879333788-git-send-email-hskinnemoen@atmel.com> (raw)

At some point before 2.6.20, the mmc subsystem moved the card
detection code to its own workqueue. One consequence of this change
is that when using an mmc card as a root device, the card may get
detected after the init task attempts to mount the root filesystem,
causing a kernel panic because the root device could not be opened.

This patch adds a call to mmc_flush_scheduled_work() late in the boot
sequence so that we can be sure the mmc card detection scans are
complete before attempting to use an mmc device as a root device.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
 drivers/mmc/core/sysfs.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/core/sysfs.c b/drivers/mmc/core/sysfs.c
index 843b1fb..168b20f 100644
--- a/drivers/mmc/core/sysfs.c
+++ b/drivers/mmc/core/sysfs.c
@@ -358,3 +358,16 @@ static void __exit mmc_exit(void)
 
 module_init(mmc_init);
 module_exit(mmc_exit);
+
+#ifndef MODULE
+/*
+ * Make sure scanning for new cards has completed before attempting
+ * to mount the root filesystem.
+ */
+static int __init mmc_finish_detect(void)
+{
+	mmc_flush_scheduled_work();
+	return 0;
+}
+late_initcall(mmc_finish_detect);
+#endif
-- 
1.4.4.4


             reply	other threads:[~2007-05-10 10:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-10 10:35 Haavard Skinnemoen [this message]
2007-05-10 12:04 ` Pierre Ossman
2007-05-10 12:37   ` Haavard Skinnemoen
2007-05-10 13:45     ` Pierre Ossman
2007-05-10 14:33       ` Haavard Skinnemoen
2007-05-10 15:58         ` Pierre Ossman
2007-05-10 16:27           ` Haavard Skinnemoen
2007-05-10 17:51             ` Matt Reimer
2007-05-11  7:44               ` Haavard Skinnemoen
2007-05-10 19:41             ` Pierre Ossman
2007-05-11  8:39               ` Haavard Skinnemoen
2007-05-13 13:34                 ` Pierre Ossman
2007-05-13 13:47                   ` Haavard Skinnemoen
2007-05-13 14:24                     ` Pierre Ossman
2007-05-13 14:37                       ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=117879333788-git-send-email-hskinnemoen@atmel.com \
    --to=hskinnemoen@atmel.com \
    --cc=drzeus@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®