mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubi: kill homegrown endian macros
Date: Thu, 17 May 2007 17:50:43 +0300	[thread overview]
Message-ID: <1179413443.3642.49.camel@sauron> (raw)
In-Reply-To: <20070517143200.GA30850@lst.de>

Christoph,

On Thu, 2007-05-17 at 16:32 +0200, Christoph Hellwig wrote:
> Kill ubis homegrown endianess handling crap and replace it with
> the normal kernel endianess handling.

Err,__be32 and the company are just sparse things, while I have compiler
checks with my struct ubi32_t and friends. JFFS2 also uses the same
technique. Why do you force me to rely on sparse instead instead of
compiler?

Well, I see the good side of your change - no home-brewed media<->cpu
things. Fair enough and nice. But why don't you make __be32 a struct
(just like I do) so that compiler could complain then?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)


  reply	other threads:[~2007-05-17 14:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 14:32 Christoph Hellwig
2007-05-17 14:50 ` Artem Bityutskiy [this message]
2007-05-17 14:56   ` Christoph Hellwig
2007-05-17 15:09     ` Artem Bityutskiy
2007-05-17 17:29       ` Andrew Morton
2007-05-17 17:46         ` Artem Bityutskiy
2007-05-17 18:18           ` Andrew Morton
2007-05-17 20:32             ` Artem Bityutskiy
2007-05-17 20:30         ` Matthieu CASTET
2007-05-18  2:39           ` David Woodhouse
2007-05-18  2:57             ` John Anthony Kazos Jr.
2007-05-18  3:17               ` David Woodhouse
2007-05-18 11:52                 ` John Anthony Kazos Jr.
2007-05-18 14:52                   ` David Woodhouse
2007-05-18 22:00                     ` Segher Boessenkool
2007-05-19  2:07                       ` David Woodhouse
2007-05-19 12:24                         ` Segher Boessenkool
2007-05-20 11:29                           ` David Woodhouse
2007-05-18 19:55             ` matthieu castet
2007-05-19  1:29               ` David Woodhouse
2007-05-18 20:30             ` matthieu castet
2007-05-17 20:42         ` Al Viro
2007-05-17 20:53           ` Al Viro
2007-05-18  6:58             ` Artem Bityutskiy
2007-05-18  8:38               ` Al Viro
2007-05-17 21:14           ` Dmitry Torokhov
2007-05-17 21:29             ` Al Viro
2007-05-17 21:33             ` David Miller
2007-05-17 21:47               ` Al Viro
2007-05-17 21:26           ` Al Viro
2007-05-17 20:56   ` David Miller
2007-05-17 21:03     ` Al Viro
2007-05-17 15:50 ` David Woodhouse
2007-05-17 18:12   ` Christoph Hellwig
2007-05-17 18:23     ` Sam Ravnborg
2007-05-17 18:36       ` Christoph Hellwig
2007-05-17 20:18         ` Jeremy Fitzhardinge
2007-05-17 20:27 ` Matthieu CASTET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179413443.3642.49.camel@sauron \
    --to=dedekind@infradead.org \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome