From: David Woodhouse <dwmw2@infradead.org>
To: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>
Cc: Matthieu CASTET <castet.matthieu@free.fr>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubi: kill homegrown endian macros
Date: Fri, 18 May 2007 22:52:39 +0800 [thread overview]
Message-ID: <1179499959.2859.579.camel@shinybook.infradead.org> (raw)
In-Reply-To: <alpine.DEB.0.99.0705180750550.8830@sigma.j-a-k-j.com>
On Fri, 2007-05-18 at 07:52 -0400, John Anthony Kazos Jr. wrote:
> Out of curiosity, why would a compiler ever insert padding in a structure
> that has all its elements properly-aligned?
Well, it might decide it would be nicer if some elements were aligned to
64 bits. Or to a cache line. Or something. I don't care about _why_ --
the point is that it's _allowed_ to. Hence the original use of
__attribute__((packed)).
In practice, there's no real reason why it would do such a thing, which
is why I removed the packed attribute and replaced it with a runtime
check on the size of the structures in question.
--
dwmw2
next prev parent reply other threads:[~2007-05-18 14:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-17 14:32 Christoph Hellwig
2007-05-17 14:50 ` Artem Bityutskiy
2007-05-17 14:56 ` Christoph Hellwig
2007-05-17 15:09 ` Artem Bityutskiy
2007-05-17 17:29 ` Andrew Morton
2007-05-17 17:46 ` Artem Bityutskiy
2007-05-17 18:18 ` Andrew Morton
2007-05-17 20:32 ` Artem Bityutskiy
2007-05-17 20:30 ` Matthieu CASTET
2007-05-18 2:39 ` David Woodhouse
2007-05-18 2:57 ` John Anthony Kazos Jr.
2007-05-18 3:17 ` David Woodhouse
2007-05-18 11:52 ` John Anthony Kazos Jr.
2007-05-18 14:52 ` David Woodhouse [this message]
2007-05-18 22:00 ` Segher Boessenkool
2007-05-19 2:07 ` David Woodhouse
2007-05-19 12:24 ` Segher Boessenkool
2007-05-20 11:29 ` David Woodhouse
2007-05-18 19:55 ` matthieu castet
2007-05-19 1:29 ` David Woodhouse
2007-05-18 20:30 ` matthieu castet
2007-05-17 20:42 ` Al Viro
2007-05-17 20:53 ` Al Viro
2007-05-18 6:58 ` Artem Bityutskiy
2007-05-18 8:38 ` Al Viro
2007-05-17 21:14 ` Dmitry Torokhov
2007-05-17 21:29 ` Al Viro
2007-05-17 21:33 ` David Miller
2007-05-17 21:47 ` Al Viro
2007-05-17 21:26 ` Al Viro
2007-05-17 20:56 ` David Miller
2007-05-17 21:03 ` Al Viro
2007-05-17 15:50 ` David Woodhouse
2007-05-17 18:12 ` Christoph Hellwig
2007-05-17 18:23 ` Sam Ravnborg
2007-05-17 18:36 ` Christoph Hellwig
2007-05-17 20:18 ` Jeremy Fitzhardinge
2007-05-17 20:27 ` Matthieu CASTET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179499959.2859.579.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=castet.matthieu@free.fr \
--cc=jakj@j-a-k-j.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®