From: muli@il.ibm.com
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
jdmason@kudzu.us, michaelv@il.ibm.com,
guillaume.thouvenin@ext.bull.net, muli@il.ibm.com
Subject: [PATCH 3/15] x86-64: Calgary - introduce handle_quirks() for various chipset quirks
Date: Tue, 22 May 2007 04:05:52 -0400 [thread overview]
Message-ID: <11798211663773-git-send-email-muli@il.ibm.com> (raw)
In-Reply-To: <11798211643144-git-send-email-muli@il.ibm.com>
From: Muli Ben-Yehuda <muli@il.ibm.com>
Move the aic94xx split completion timeout handling there.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
---
arch/x86_64/kernel/pci-calgary.c | 25 +++++++++++++++++--------
1 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index b1ab0d5..9f6dd44 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -807,6 +807,20 @@ static void __init calgary_set_split_com
readq(target); /* flush */
}
+static void __init calgary_handle_quirks(struct pci_dev* dev)
+{
+ unsigned char busnum = dev->bus->number;
+ struct iommu_table *tbl = dev->sysdata;
+
+ /*
+ * Give split completion a longer timeout on bus 1 for aic94xx
+ * http://bugzilla.kernel.org/show_bug.cgi?id=7180
+ */
+ if (busnum == 1)
+ calgary_set_split_completion_timeout(tbl->bbar, busnum,
+ CCR_2SEC_TIMEOUT);
+}
+
static void __init calgary_enable_translation(struct pci_dev *dev)
{
u32 val32;
@@ -831,14 +845,6 @@ static void __init calgary_enable_transl
writel(cpu_to_be32(val32), target);
readl(target); /* flush */
- /*
- * Give split completion a longer timeout on bus 1 for aic94xx
- * http://bugzilla.kernel.org/show_bug.cgi?id=7180
- */
- if (busnum == 1)
- calgary_set_split_completion_timeout(bbar, busnum,
- CCR_2SEC_TIMEOUT);
-
init_timer(&tbl->watchdog_timer);
tbl->watchdog_timer.function = &calgary_watchdog;
tbl->watchdog_timer.data = (unsigned long)dev;
@@ -890,6 +896,9 @@ static int __init calgary_init_one(struc
pci_dev_get(dev);
dev->bus->self = dev;
+
+ calgary_handle_quirks(dev);
+
calgary_enable_translation(dev);
return 0;
--
1.4.4
next prev parent reply other threads:[~2007-05-22 8:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 8:05 Calgary updates for 2.6.23 muli
2007-05-22 8:05 ` [PATCH 1/15] x86-64: Calgary - generalize calgary_increase_split_completion_timeout muli
2007-05-22 8:05 ` [PATCH 2/15] x86-64: Calgary - update copyright notice muli
2007-05-22 8:05 ` muli [this message]
2007-05-22 8:05 ` [PATCH 4/15] x86-64: Calgary - introduce chipset specific ops muli
2007-05-22 8:05 ` [PATCH 5/15] x86-64: Calgary - abstract how we find the iommu_table for a device muli
2007-05-22 8:05 ` [PATCH 6/15] x86-64: Calgary - introduce CalIOC2 support muli
2007-05-22 8:05 ` [PATCH 7/15] x86-64: Calgary - add chip_ops and a quirk function for CalIOC2 muli
2007-05-22 8:05 ` [PATCH 8/15] x86-64: Calgary - implement CalIOC2 TCE cache flush sequence muli
2007-05-22 8:05 ` [PATCH 9/15] x86-64: Calgary - make dump_error_regs a chip op muli
2007-05-22 8:05 ` [PATCH 10/15] x86-64: Calgary - grab PLSSR too when a DMA error occurs muli
2007-05-22 8:06 ` [PATCH 11/15] x86-64: Calgary - reserve TCEs with the same address as MEM regions muli
2007-05-22 8:06 ` [PATCH 12/15] x86-64: Calgary - cleanup of unneeded macros muli
2007-05-22 8:06 ` [PATCH 13/15] x86-64: Calgary - tabify and trim trailing whitespace muli
2007-05-22 8:06 ` [PATCH 14/15] x86-64: Calgary - only reserve the first 1MB of IO space for CalIOC2 muli
2007-05-22 8:06 ` [PATCH 15/15] x86-64: Calgary - tidy up debug printks muli
[not found] ` <20070604113344.0e71ca8c.akpm@linux-foundation.org>
2007-06-04 19:06 ` [PATCH 5/15] x86-64: Calgary - abstract how we find the iommu_table for a device Jeff Garzik
2007-06-04 19:13 ` Muli Ben-Yehuda
2007-06-04 19:31 ` Jeff Garzik
2007-06-04 21:05 ` [PATCH] stop x86 ->sysdata abuse; introduce pci_sysdata Jeff Garzik
2007-06-04 23:27 ` Keshavamurthy, Anil S
2007-06-05 10:29 ` Muli Ben-Yehuda
2007-06-06 21:03 ` Muli Ben-Yehuda
2007-06-06 21:21 ` Jeff Garzik
2007-06-06 21:26 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11798211663773-git-send-email-muli@il.ibm.com \
--to=muli@il.ibm.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelv@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®