From: muli@il.ibm.com
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org, discuss@x86-64.org,
jdmason@kudzu.us, michaelv@il.ibm.com,
guillaume.thouvenin@ext.bull.net, muli@il.ibm.com
Subject: [PATCH 11/15] x86-64: Calgary - reserve TCEs with the same address as MEM regions
Date: Tue, 22 May 2007 04:06:00 -0400 [thread overview]
Message-ID: <11798211673144-git-send-email-muli@il.ibm.com> (raw)
In-Reply-To: <1179821167443-git-send-email-muli@il.ibm.com>
From: Muli Ben-Yehuda <muli@il.ibm.com>
This works around a bug where DMAs that have the same addresses as
some MEM regions do not go through. Not clear yet if this is due to a
mis-configuration or something deeper.
Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com>
---
arch/x86_64/kernel/pci-calgary.c | 67 ++++++++++++++++++++++++++++++++++++++
1 files changed, 67 insertions(+), 0 deletions(-)
diff --git a/arch/x86_64/kernel/pci-calgary.c b/arch/x86_64/kernel/pci-calgary.c
index a49b19d..9efecf3 100644
--- a/arch/x86_64/kernel/pci-calgary.c
+++ b/arch/x86_64/kernel/pci-calgary.c
@@ -1538,3 +1538,70 @@ static int __init calgary_parse_options(
return 1;
}
__setup("calgary=", calgary_parse_options);
+
+static void __init calgary_fixup_one_tce_space(struct pci_dev *dev)
+{
+ struct iommu_table *tbl;
+ unsigned int npages;
+ int i;
+
+ tbl = dev->sysdata;
+
+ for (i = 0; i < 4; i++) {
+ struct resource *r = &dev->resource[PCI_BRIDGE_RESOURCES + i];
+
+ /* Don't give out TCEs that map MEM resources */
+ if (!(r->flags & IORESOURCE_MEM))
+ continue;
+
+ /* 0-based? we reserve the whole 1st MB anyway */
+ if (!r->start)
+ continue;
+
+ /* cover the whole region */
+ npages = (r->end - r->start) >> PAGE_SHIFT;
+ npages++;
+
+ printk(KERN_DEBUG "Calg: dev %p [%x] tbl %p reserving "
+ "0x%Lx-0x%Lx [0x%x pages]\n", dev, dev->bus->number,
+ tbl, r->start, r->end, npages);
+
+ iommu_range_reserve(tbl, r->start, npages);
+ }
+}
+
+static int __init calgary_fixup_tce_spaces(void)
+{
+ struct pci_dev *dev = NULL;
+ void* tce_space;
+
+ if (no_iommu || swiotlb || !calgary_detected)
+ return -ENODEV;
+
+ printk(KERN_DEBUG "Calgary: fixing tce spaces\n");
+
+ do {
+ dev = pci_get_device(PCI_VENDOR_ID_IBM, PCI_ANY_ID, dev);
+ if (!dev)
+ break;
+ if (!is_cal_pci_dev(dev->device))
+ continue;
+ if (!translate_phb(dev))
+ continue;
+
+ tce_space = bus_info[dev->bus->number].tce_space;
+ if (!tce_space)
+ continue;
+
+ calgary_fixup_one_tce_space(dev);
+
+ } while (1);
+
+ return 0;
+}
+
+/*
+ * We need to be call after pcibios_assign_resources (fs_initcall level)
+ * and before device_initcall.
+ */
+rootfs_initcall(calgary_fixup_tce_spaces);
--
1.4.4
next prev parent reply other threads:[~2007-05-22 8:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-22 8:05 Calgary updates for 2.6.23 muli
2007-05-22 8:05 ` [PATCH 1/15] x86-64: Calgary - generalize calgary_increase_split_completion_timeout muli
2007-05-22 8:05 ` [PATCH 2/15] x86-64: Calgary - update copyright notice muli
2007-05-22 8:05 ` [PATCH 3/15] x86-64: Calgary - introduce handle_quirks() for various chipset quirks muli
2007-05-22 8:05 ` [PATCH 4/15] x86-64: Calgary - introduce chipset specific ops muli
2007-05-22 8:05 ` [PATCH 5/15] x86-64: Calgary - abstract how we find the iommu_table for a device muli
2007-05-22 8:05 ` [PATCH 6/15] x86-64: Calgary - introduce CalIOC2 support muli
2007-05-22 8:05 ` [PATCH 7/15] x86-64: Calgary - add chip_ops and a quirk function for CalIOC2 muli
2007-05-22 8:05 ` [PATCH 8/15] x86-64: Calgary - implement CalIOC2 TCE cache flush sequence muli
2007-05-22 8:05 ` [PATCH 9/15] x86-64: Calgary - make dump_error_regs a chip op muli
2007-05-22 8:05 ` [PATCH 10/15] x86-64: Calgary - grab PLSSR too when a DMA error occurs muli
2007-05-22 8:06 ` muli [this message]
2007-05-22 8:06 ` [PATCH 12/15] x86-64: Calgary - cleanup of unneeded macros muli
2007-05-22 8:06 ` [PATCH 13/15] x86-64: Calgary - tabify and trim trailing whitespace muli
2007-05-22 8:06 ` [PATCH 14/15] x86-64: Calgary - only reserve the first 1MB of IO space for CalIOC2 muli
2007-05-22 8:06 ` [PATCH 15/15] x86-64: Calgary - tidy up debug printks muli
[not found] ` <20070604113344.0e71ca8c.akpm@linux-foundation.org>
2007-06-04 19:06 ` [PATCH 5/15] x86-64: Calgary - abstract how we find the iommu_table for a device Jeff Garzik
2007-06-04 19:13 ` Muli Ben-Yehuda
2007-06-04 19:31 ` Jeff Garzik
2007-06-04 21:05 ` [PATCH] stop x86 ->sysdata abuse; introduce pci_sysdata Jeff Garzik
2007-06-04 23:27 ` Keshavamurthy, Anil S
2007-06-05 10:29 ` Muli Ben-Yehuda
2007-06-06 21:03 ` Muli Ben-Yehuda
2007-06-06 21:21 ` Jeff Garzik
2007-06-06 21:26 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11798211673144-git-send-email-muli@il.ibm.com \
--to=muli@il.ibm.com \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelv@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®