Re: [PATCH v5] arm64: dts: qcom: lemans-evk: Add OTG support for primary USB controller

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 11/25/25 12:04 PM, Krishna Kurapati wrote:
> Enable OTG support for primary USB controller on EVK Platform. Add
> HD3SS3220 Type-C port controller present between Type-C port and SoC
> that provides role switch notifications to controller.
> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---

[...]

> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -4026,7 +4026,27 @@ usb_0: usb@a600000 {
>  			snps,dis-u1-entry-quirk;
>  			snps,dis-u2-entry-quirk;
>  
> +			usb-role-switch;
>  			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					usb3_0_hs_ep: endpoint {

The patch looks good, but I'm a little puzzled why the endpoints of 'usb_0' are
named 'usb3_0'.. This will make the DTs look like:

&usb_0 {
	// foo
};

&usb_1 {
	// foo
};

// usb_0 children
&usb3_0_hs_ep {
	// foo
};


&usb3_0_ss_ep {
	// foo
};

// usb_1 children
&usb3_1_hs_ep {
	// foo
};

&usb3_1_ss_ep {
	// foo
};

Konrad