mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH RT] Remove double warning print with faulty preempt disable nesting
@ 2007-06-19 20:23 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2007-06-19 20:23 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Thomas Gleixner, LKML, RT

On a faulty preempt disable bug we print out a warning but then we go
and call preempt_enable_no_resched, which also can print out a warning.
This is redundant.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.21-rt9/lib/smp_processor_id.c
===================================================================
--- linux-2.6.21-rt9.orig/lib/smp_processor_id.c
+++ linux-2.6.21-rt9/lib/smp_processor_id.c
@@ -47,7 +47,11 @@ unsigned int notrace debug_smp_processor
 	dump_stack();
 
 out_enable:
-	preempt_enable_no_resched();
+	/*
+	 * Don't print message if we enable to zero.
+	 * We arleady printed a warning up above.
+	 */
+	__preempt_enable_no_resched();
 out:
 	return this_cpu;
 }



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-19 20:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-19 20:23 [PATCH RT] Remove double warning print with faulty preempt disable nesting Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®