mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] lguest: fix TSC "divide error: 0000 [#1]" boot crash
@ 2007-06-29  1:30 Rusty Russell
  0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2007-06-29  1:30 UTC (permalink / raw)
  To: Matt Mackall; +Cc: lkml - Kernel Mailing List, Andrew Morton

Configuring a guest with < CONFIG_M586TSC reveals an lguest bug: the
TSC code expects to see the TSC capability bit, but we weren't setting
up the capabilities until much later in check_bugs ->
identify_boot_cpu -> identify_boot_cpu.

Do the same thing as Xen and the head.S native code: populate the
first capability word before start_kernel().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff -r 7743cd1639b7 drivers/lguest/lguest.c
--- a/drivers/lguest/lguest.c	Thu Jun 28 23:21:41 2007 +1000
+++ b/drivers/lguest/lguest.c	Fri Jun 29 06:23:59 2007 +1000
@@ -598,6 +598,9 @@ __init void lguest_init(void *boot)
 	paravirt_disable_iospace();
 
 	cpu_detect(&new_cpu_data);
+	/* head.S usually sets up the first capability word, so do it here. */
+	new_cpu_data.x86_capability[0] = cpuid_edx(1);
+	
 	/* Math is always hard! */
 	new_cpu_data.hard_math = 1;
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-06-29  1:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-29  1:30 [PATCH] lguest: fix TSC "divide error: 0000 [#1]" boot crash Rusty Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®