From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: pe1rxq@amsat.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] se401: fix "&& 0x" typo
Date: Mon, 02 Jul 2007 11:46:42 -0300 [thread overview]
Message-ID: <1183387602.5456.106.camel@gaivota> (raw)
In-Reply-To: <20070702110453.GA6634@localhost.sw.ru>
Em Seg, 2007-07-02 às 15:04 +0400, Alexey Dobriyan escreveu:
> Code there survived trivial regexp made earlier, but after bulk preprocessing
> was done...
>
> ===> if (!cp[2] && 0x40) { <===
> printk("<3>" "%s: " "Bayer format not supported!" ...
> return 1;
> }
>
>
> NOTE: to me, check or error message should be reverted, but I know nothing
> about this driver.
Your patch looks to be coherent. However, I suspect that this will break
the driver. There are some functions at the driver for decoding Bayer
format. Without your patch, the if condition will never occur. So, Bayer
decoding will work.
IMO, the better is to add an #if 0 at the test.
--
Cheers,
Mauro
prev parent reply other threads:[~2007-07-02 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 11:04 Alexey Dobriyan
2007-07-02 14:46 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183387602.5456.106.camel@gaivota \
--to=mchehab@infradead.org \
--cc=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1rxq@amsat.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®