From: Alexey Dobriyan <adobriyan@sw.ru>
To: pe1rxq@amsat.org, v4l-dvb-maintainer@linuxtv.org
Cc: linux-kernel@vger.kernel.org, devel@openvz.org
Subject: [PATCH] se401: fix "&& 0x" typo
Date: Mon, 2 Jul 2007 15:04:53 +0400 [thread overview]
Message-ID: <20070702110453.GA6634@localhost.sw.ru> (raw)
Code there survived trivial regexp made earlier, but after bulk preprocessing
was done...
===> if (!cp[2] && 0x40) { <===
printk("<3>" "%s: " "Bayer format not supported!" ...
return 1;
}
NOTE: to me, check or error message should be reverted, but I know nothing
about this driver.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
drivers/media/video/se401.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -1280,7 +1280,7 @@ static int se401_init(struct usb_se401 *se401, int button)
rc=se401_sndctrl(0, se401, SE401_REQ_GET_HEIGHT, 0, cp, sizeof(cp));
se401->cheight=cp[0]+cp[1]*256;
- if (!cp[2] && SE401_FORMAT_BAYER) {
+ if (!(cp[2] & SE401_FORMAT_BAYER)) {
err("Bayer format not supported!");
return 1;
}
next reply other threads:[~2007-07-02 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 11:04 Alexey Dobriyan [this message]
2007-07-02 14:46 ` [v4l-dvb-maintainer] " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070702110453.GA6634@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pe1rxq@amsat.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®