From: Eric Van Hensbergen <ericvh@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Meelis Roos <mroos@linux.ee>, Eric Van Hensbergren <ericvh@gmail.com>
Subject: [PATCH] 9p: fix debug compilation error
Date: Mon, 16 Jul 2007 09:47:49 -0500 [thread overview]
Message-ID: <11845972692586-git-send-email-ericvh@gmail.com> (raw)
In-Reply-To: <Pine.SOC.4.64.0707161432480.1471@math.ut.ee>
From: Meelis Roos <mroos@linux.ee>
With 9P but no 9P debug options, this error occurs:
CC [M] fs/9p/v9fs.o
fs/9p/v9fs.c: In function 'v9fs_parse_options':
fs/9p/v9fs.c:134: error: 'p9_debug_level' undeclared (first use in this function)
The following patch moves the definition of p9_debug_level out of #ifdef
and seems to fix the problem.
(Original patch took care of the extern definition in the includes, but
not the actual definition in mod.c - ericvh)
Signed-off-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Eric Van Hensbergren <ericvh@gmail.com>
---
include/net/9p/9p.h | 4 ++--
net/9p/mod.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/net/9p/9p.h b/include/net/9p/9p.h
index 88884d3..8fc3796 100644
--- a/include/net/9p/9p.h
+++ b/include/net/9p/9p.h
@@ -27,6 +27,8 @@
#ifndef NET_9P_H
#define NET_9P_H
+extern unsigned int p9_debug_level;
+
#ifdef CONFIG_NET_9P_DEBUG
#define P9_DEBUG_ERROR (1<<0)
@@ -38,8 +40,6 @@
#define P9_DEBUG_SLABS (1<<7)
#define P9_DEBUG_FCALL (1<<8)
-extern unsigned int p9_debug_level;
-
#define P9_DPRINTK(level, format, arg...) \
do { \
if ((p9_debug_level & level) == level) \
diff --git a/net/9p/mod.c b/net/9p/mod.c
index 4f9e1d2..951bb1d 100644
--- a/net/9p/mod.c
+++ b/net/9p/mod.c
@@ -28,12 +28,10 @@
#include <linux/moduleparam.h>
#include <net/9p/9p.h>
-#ifdef CONFIG_NET_9P_DEBUG
unsigned int p9_debug_level = 0; /* feature-rific global debug level */
EXPORT_SYMBOL(p9_debug_level);
module_param_named(debug, p9_debug_level, uint, 0);
MODULE_PARM_DESC(debug, "9P debugging level");
-#endif
extern int p9_mux_global_init(void);
extern void p9_mux_global_exit(void);
--
1.5.0.2.gfbe3d-dirty
next prev parent reply other threads:[~2007-07-16 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 11:41 9P compile fix Meelis Roos
2007-07-16 14:47 ` Eric Van Hensbergen [this message]
2007-07-16 15:49 ` [PATCH] 9p: fix debug compilation error Dave Jones
2007-07-16 21:02 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11845972692586-git-send-email-ericvh@gmail.com \
--to=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®