From: Dave Jones <davej@redhat.com>
To: Eric Van Hensbergen <ericvh@gmail.com>
Cc: linux-kernel@vger.kernel.org, Meelis Roos <mroos@linux.ee>
Subject: Re: [PATCH] 9p: fix debug compilation error
Date: Mon, 16 Jul 2007 11:49:39 -0400 [thread overview]
Message-ID: <20070716154939.GA30789@redhat.com> (raw)
In-Reply-To: <11845972692586-git-send-email-ericvh@gmail.com>
On Mon, Jul 16, 2007 at 09:47:49AM -0500, Eric Van Hensbergen wrote:
> From: Meelis Roos <mroos@linux.ee>
>
> With 9P but no 9P debug options, this error occurs:
> CC [M] fs/9p/v9fs.o
> fs/9p/v9fs.c: In function 'v9fs_parse_options':
> fs/9p/v9fs.c:134: error: 'p9_debug_level' undeclared (first use in this function)
>
> The following patch moves the definition of p9_debug_level out of #ifdef
> and seems to fix the problem.
>
> (Original patch took care of the extern definition in the includes, but
> not the actual definition in mod.c - ericvh)
Seems somewhat wasteful to include the debug options when the config
option has been disabled though.
Wouldn't something like this (untested) make more sense ?
Dave
---
fs/9p/v9fs.c: In function 'v9fs_parse_options':
fs/9p/v9fs.c:134: error: 'p9_debug_level' undeclared (first use in this function)
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.22.noarch/fs/9p/v9fs.c~ 2007-07-16 11:45:56.000000000 -0400
+++ linux-2.6.22.noarch/fs/9p/v9fs.c 2007-07-16 11:46:12.000000000 -0400
@@ -131,7 +131,9 @@ static void v9fs_parse_options(char *opt
switch (token) {
case Opt_debug:
v9ses->debug = option;
+#ifdef CONFIG_NET_9P_DEBUG
p9_debug_level = option;
+#endif
break;
case Opt_port:
v9ses->port = option;
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-07-16 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 11:41 9P compile fix Meelis Roos
2007-07-16 14:47 ` [PATCH] 9p: fix debug compilation error Eric Van Hensbergen
2007-07-16 15:49 ` Dave Jones [this message]
2007-07-16 21:02 ` Eric Van Hensbergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070716154939.GA30789@redhat.com \
--to=davej@redhat.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®