From: Ian Kent <raven@themaw.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Chuck Ebbert <cebbert@redhat.com>,
Bill Davidsen <davidsen@tmr.com>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch] CFS scheduler, -v19
Date: Tue, 17 Jul 2007 19:17:00 +0800 [thread overview]
Message-ID: <1184671021.3188.51.camel@raven.themaw.net> (raw)
In-Reply-To: <20070717074537.GA13539@elte.hu>
On Tue, 2007-07-17 at 09:45 +0200, Ingo Molnar wrote:
> * Ian Kent <raven@themaw.net> wrote:
>
> > Yes it does and I have two reported bugs so far.
> >
> > In several places I have code similar to:
> >
> > wait.tv_sec = time(NULL) + 1;
> > wait.tv_nsec = 0;
> >
> > signaled = 0;
> > while (!signaled) {
> > status = pthread_cond_timedwait(&cond, &mutex, &wait);
> > if (status) {
> > if (status == ETIMEDOUT)
> > break;
> > fatal(status);
> > }
> > }
>
> ah! It passes in a low-res time source into a high-res time interface
> (pthread_cond_timedwait()). Could you change the time(NULL) + 1 to
> time(NULL) + 2, or change it to:
>
> gettimeofday(&wait, NULL);
> wait.tv_sec++;
OK, I'm with you, hi-res timer.
But even so, how is the time in the past after adding a second.
Is it because I'm not setting tv_nsec when it's close to a second
boundary, and hence your recommendation above?
>
> does this solve the spinning?
I don't have a system to test this on so I'll try to get one of the
people that logged the problem to test a patch.
>
> i'm wondering how widespread this is. If automount is the only app doing
> this then _maybe_ we could get away with it by changing automount?
I'm happy to change automount but that could cause odd version specific
problems for people updating their kernel on an older installed base.
Aaah .. and they'll all blame me!! ;)
Ian
next prev parent reply other threads:[~2007-07-17 11:17 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 17:33 Ingo Molnar
2007-07-08 17:46 ` Willy Tarreau
2007-07-09 22:39 ` Ingo Molnar
2007-07-17 21:44 ` Willy Tarreau
2007-07-10 8:08 ` Mike Galbraith
2007-07-11 17:26 ` Bill Davidsen
2007-07-11 20:55 ` Ingo Molnar
2007-07-12 12:41 ` Bill Davidsen
2007-07-13 21:19 ` Bill Davidsen
2007-07-16 21:34 ` Chuck Ebbert
2007-07-16 21:55 ` Ingo Molnar
2007-07-17 4:22 ` Bill Davidsen
2007-07-17 5:01 ` Ian Kent
2007-07-17 7:45 ` Ingo Molnar
2007-07-17 11:17 ` Ian Kent [this message]
2007-07-17 17:16 ` Ingo Molnar
2007-07-18 1:24 ` Bill Davidsen
2007-07-18 6:19 ` Ian Kent
2007-07-17 16:30 ` Chuck Ebbert
2007-07-17 21:16 ` David Schwartz
2007-07-18 5:59 ` Ian Kent
2007-07-18 7:54 ` Ingo Molnar
2007-07-18 13:50 ` Bill Davidsen
2007-07-18 17:23 ` Linus Torvalds
2007-07-18 16:03 ` Linus Torvalds
2007-07-18 17:31 ` Ian Kent
2007-07-18 21:37 ` Bill Davidsen
2007-07-19 8:53 ` Ingo Molnar
2007-07-19 14:32 ` Ingo Molnar
2007-07-19 17:06 ` Bill Davidsen
2007-07-19 17:10 ` Ingo Molnar
2007-07-19 17:17 ` Ingo Molnar
2007-07-19 17:26 ` Bill Davidsen
2007-07-19 17:42 ` Ingo Molnar
2007-07-20 2:32 ` Bill Davidsen
2007-07-19 8:16 ` Ingo Molnar
2007-07-14 11:34 ` Markus
2007-07-14 15:11 ` Markus
2007-07-16 9:41 ` Ingo Molnar
2007-07-16 17:59 ` Markus
2007-07-17 7:37 ` Ingo Molnar
2007-07-17 13:06 ` Markus
2007-07-17 17:06 ` Ingo Molnar
2007-07-17 17:13 ` Ingo Molnar
2007-07-17 19:42 ` Markus
2007-07-17 20:09 ` Ingo Molnar
2007-07-17 20:37 ` Linus Torvalds
2007-07-17 20:43 ` Ingo Molnar
2007-07-17 22:03 ` Markus
2007-07-20 22:26 ` Markus
2007-07-22 11:59 ` konqueror suddenly vanishing, "konqueror: Fatal IO error: client killed" Ingo Molnar
2007-07-22 14:26 ` Markus
2007-08-09 17:34 ` [patch] CFS scheduler, -v19 Markus
2007-08-10 7:46 ` Ingo Molnar
2007-08-14 17:15 ` Markus
2007-10-17 0:02 ` Markus
2007-07-14 17:19 ` Ed Tomlinson
2007-07-15 5:25 ` Mike Galbraith
2007-07-15 12:53 ` Markus
2007-07-15 19:46 ` Mike Galbraith
2007-07-15 21:11 ` Markus
2007-07-16 6:42 ` Mike Galbraith
2007-07-16 8:00 ` Ingo Molnar
2007-07-16 9:17 ` Ingo Molnar
2007-07-16 11:10 ` Ed Tomlinson
2007-07-08 20:51 Al Boldi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184671021.3188.51.camel@raven.themaw.net \
--to=raven@themaw.net \
--cc=cebbert@redhat.com \
--cc=davidsen@tmr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®