mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-input@atrey.karlin.mff.cuni.cz,
	linux-usb-devel@lists.sourceforge.net,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Nicolas Boichat <nicolas@boichat.ch>,
	Michael Hanselmann <linux-kernel@hansmi.ch>,
	Peter Osterlund <petero2@telia.com>,
	Frank Arnold <frank@scirocco-5v-turbo.de>,
	Stelian Pop <stelian@popies.net>,
	Greg Kroah-Hartman <greg@kroah.com>
Subject: Re: [PATCH] appletouch powersaving - please apply for 2.6.23-rc1
Date: Tue, 17 Jul 2007 15:03:44 +0200	[thread overview]
Message-ID: <1184677424.3773.87.camel@johannes.berg> (raw)
In-Reply-To: <1184656218.14051.43.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

Hi,

Good stuff :)

> +	int                     idlecount;      /* number of empty packets */

should probably use tabs here.

> +	size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> +			       ATP_GEYSER3_MODE_WRITE_REQUEST_ID,
> +			       USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE,
> +			       ATP_GEYSER3_MODE_REQUEST_VALUE,
> +			       ATP_GEYSER3_MODE_REQUEST_INDEX, &data, 8, 5000);
> +	<eol>

trailing whitespace.

 
> +	input_report_key(dev->input, BTN_LEFT, dev->data[dev->datalen-1] & 1);
> +


> @@ -449,10 +511,19 @@ static void atp_complete(struct urb* urb)
>  
>  		/* reset the accumulator on release */
>  		memset(dev->xy_acc, 0, sizeof(dev->xy_acc));
> -	}
>  
> -	input_report_key(dev->input, BTN_LEFT,
> -			 !!dev->data[dev->datalen - 1]);

Any hint as to why you move this? The different test, yes, ok, you
explained that, but moving it?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  reply	other threads:[~2007-07-17 13:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-17  7:10 Soeren Sonnenburg
2007-07-17 13:03 ` Johannes Berg [this message]
2007-07-17 16:14   ` Soeren Sonnenburg
2007-07-17 15:01 ` Dmitry Torokhov
2007-07-17 18:16   ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 take #3 Soeren Sonnenburg
2007-07-18  1:48     ` Dmitry Torokhov
2007-07-18  5:32       ` Soeren Sonnenburg
2007-07-18 22:57 ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 Andrew Morton
2007-07-19  3:35   ` [PATCH] appletouch powersaving - please apply for 2.6.23-rc1 - take #4 Soeren Sonnenburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1184677424.3773.87.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=frank@scirocco-5v-turbo.de \
    --cc=greg@kroah.com \
    --cc=kernel@nn7.de \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@hansmi.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=mjg59@srcf.ucam.org \
    --cc=nicolas@boichat.ch \
    --cc=petero2@telia.com \
    --cc=stelian@popies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®