mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Javier Pello <javier.pello@urjc.es>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] request_firmware: skip timeout if userspace was not  notified
Date: Tue, 07 Aug 2007 16:08:25 +0200	[thread overview]
Message-ID: <1186495705.3611.39.camel@lov.localdomain> (raw)
In-Reply-To: <46B87ACA.7010501@urjc.es>


On Tue, 2007-08-07 at 15:59 +0200, Javier Pello wrote:
> On Tue, 07 Aug 2007, Kay Sievers wrote:
> 
> > If you don't have modules and the initial request fails, how do you
> > load the firmware later?
> 
> I trigger a rebinding of the device to the driver in an init file:
> # echo -n [device] >/sys/.../bind
> 
> > The real fix would be to change the driver not to block in the
> > firmware request and use async version of firmware loading. The
> > whole firmware class with its silly timeout is just a piece of
> > crap, that needs to be replaced.
> 
> I don't think that would be a real fix. You've done away with the
> kernel blocking, but the timeout is still there, only that in the
> background, and my point is still true: it is useless to wait at
> all if userspace didn't receive the event. Waiting asynchronously
> is less annoying than waiting synchronously, but equally useless.

Nope, you would just fulfill in a completely generic way all outstanding
requests when you are ready. All requests are all nicely grouped and
visible in sysfs. There would be no need of coding your own device
specific rebind. No timeout is needed or wanted, all requests would stay
until userspace has handled them successfully or canceled them.

Kay


  reply	other threads:[~2007-08-07 14:05 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-03 19:07 Javier Pello
2007-08-04  5:21 ` david
2007-08-04  8:50   ` Javier Pello
2007-08-04 17:09     ` david
2007-08-04 21:20       ` Javier Pello
2007-08-06 12:24 ` Cornelia Huck
2007-08-06 20:23   ` Javier Pello
     [not found]     ` <20070807125844.4d756b04@gondo lin.boeblingen.de.ibm.com>
2007-08-07 10:58     ` Cornelia Huck
2007-08-07 11:46       ` Kay Sievers
2007-08-07 12:10         ` Cornelia Huck
2007-08-07 12:31           ` Kay Sievers
2007-08-07 12:48             ` Cornelia Huck
2007-08-07 12:47           ` Javier Pello
2007-08-07 12:57             ` Kay Sievers
2007-08-07 13:15               ` Cornelia Huck
2007-08-07 13:59               ` Javier Pello
2007-08-07 14:08                 ` Kay Sievers [this message]
2007-08-07 14:38                   ` Cornelia Huck
2007-08-09  9:13                   ` Javier Pello
2007-08-09  9:21                     ` Kay Sievers
2007-08-09  9:26                     ` Cornelia Huck
2007-08-07 14:26                 ` Cornelia Huck
2007-08-09  9:36                   ` Javier Pello
2007-08-09 11:58                     ` Kay Sievers
2007-08-10 21:24                       ` Javier Pello
2007-08-11 13:26                         ` Kay Sievers
2007-08-07 20:05 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1186495705.3611.39.camel@lov.localdomain \
    --to=kay.sievers@vrfy.org \
    --cc=cornelia.huck@de.ibm.com \
    --cc=greg@kroah.com \
    --cc=javier.pello@urjc.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®