* [PATCH] Fix non-TSC guest clocksource lockup
@ 2007-08-09 10:52 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2007-08-09 10:52 UTC (permalink / raw)
To: lguest, lkml - Kernel Mailing List
Cc: Linus Torvalds, Andrew Morton, tglx, ron minnich
lguest uses a host-supplied wallclock-based clocksource when the TSC
is not reliable. As this is already in nanoseconds, I naively used a
multiplier of 1 and a shift of 0.
But update_wall_time() in its infinite wisdom decides to adjust the
clock a little (where does it think it's getting a more accurate time
from?)
It will happily tweak the multiplier... to 0, then -1.
So the "fix" is to use a shift of 22 like everyone else, and a
multiplier of 1 << 22.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r e715c5d0ca6d drivers/lguest/lguest.c
--- a/drivers/lguest/lguest.c Thu Aug 09 15:08:26 2007 +1000
+++ b/drivers/lguest/lguest.c Thu Aug 09 20:42:46 2007 +1000
@@ -691,7 +691,8 @@ static struct clocksource lguest_clock =
.rating = 400,
.read = lguest_clock_read,
.mask = CLOCKSOURCE_MASK(64),
- .mult = 1,
+ .mult = 1 << 22,
+ .shift = 22,
};
/* The "scheduler clock" is just our real clock, adjusted to start at zero */
@@ -774,7 +775,6 @@ static void lguest_time_init(void)
* way, the "rating" is initialized so high that it's always chosen
* over any other clocksource. */
if (lguest_data.tsc_khz) {
- lguest_clock.shift = 22;
lguest_clock.mult = clocksource_khz2mult(lguest_data.tsc_khz,
lguest_clock.shift);
lguest_clock.flags = CLOCK_SOURCE_IS_CONTINUOUS;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-09 10:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-09 10:52 [PATCH] Fix non-TSC guest clocksource lockup Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®