mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Strange performance change 59 -> 61/62
Date: Fri, 21 Feb 2003 09:27:29 -0800	[thread overview]
Message-ID: <11870000.1045848448@[10.10.2.4]> (raw)
In-Reply-To: <20030220234522.185f3f6c.akpm@digeo.com>

>> Some more stats ... which look rather suspicious. 600% increase for
>> dentry_open and __mark_inode_dirty? Hmmmmm.
> 
> __mark_inode_dirty() just got itself an smp_mb().  Would be instructive to
> disable that.
> 
> dentry_open(): don't know - fs/open.c hasn't changed at all.  Perhaps
> dcache_rcu has caused additional pingpong?

2.5.59-mjb6             84 __mark_inode_dirty
2.5.61-mjb1            594 __mark_inode_dirty
2.5.61-mjb1-no_mb       74 __mark_inode_dirty

Yup, that fixed that one ... but presumably it was put there for a reason,
so I can't just rip it out ;-) Thanks, I'll go take a closer look at the
others.

M


  reply	other threads:[~2003-02-21 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-19 16:23 Martin J. Bligh
2003-02-19 18:19 ` Andrew Morton
2003-02-21  7:19   ` Martin J. Bligh
2003-02-21  7:28     ` Martin J. Bligh
2003-02-21  7:45       ` Andrew Morton
2003-02-21 17:27         ` Martin J. Bligh [this message]
2003-02-21 20:20           ` Andrew Morton
2003-02-22  7:46             ` Martin J. Bligh
2003-02-22  8:04               ` Andrew Morton
2003-02-22  8:10                 ` Martin J. Bligh
2003-02-19 17:19 Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='11870000.1045848448@[10.10.2.4]' \
    --to=mbligh@aracnet.com \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®