mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Satyam Sharma <satyam@infradead.org>,
	Tim Bird <tim.bird@am.sony.com>,
	linux kernel <linux-kernel@vger.kernel.org>,
	Christoph Lameter <clameter@sgi.com>
Subject: Re: kfree(0) - ok?
Date: Fri, 17 Aug 2007 11:31:54 -0700	[thread overview]
Message-ID: <1187375514.2615.0.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20070817112253.e6a7cb33.akpm@linux-foundation.org>


On Fri, 2007-08-17 at 11:22 -0700, Andrew Morton wrote:
> On Wed, 15 Aug 2007 05:12:41 +0530 (IST)
> Satyam Sharma <satyam@infradead.org> wrote:
> 
> > [PATCH] {slub, slob}: use unlikely() for kfree(ZERO_OR_NULL_PTR) check
> > 
> > Considering kfree(NULL) would normally occur only in error paths and
> > kfree(ZERO_SIZE_PTR) is uncommon as well, so let's use unlikely() for
> > the condition check in SLUB's and SLOB's kfree() to optimize for the
> > common case. SLAB has this already.
> 
> I went through my current versions of slab/slub/slub and came up with this:
> 
> diff -puN mm/slob.c~slub-slob-use-unlikely-for-kfreezero_or_null_ptr-check mm/slob.c
> --- a/mm/slob.c~slub-slob-use-unlikely-for-kfreezero_or_null_ptr-check
> +++ a/mm/slob.c
> @@ -360,7 +360,7 @@ static void slob_free(void *block, int s
>  	slobidx_t units;
>  	unsigned long flags;
>  
> -	if (ZERO_OR_NULL_PTR(block))
> +	if (unlikely(ZERO_OR_NULL_PTR(block)))



btw this makes NO sense at all; gcc already defaults to assuming
unlikely if you check a pointer for NULL....


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org


  reply	other threads:[~2007-08-17 18:36 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-14 22:59 Tim Bird
2007-08-14 22:55 ` Arjan van de Ven
2007-08-14 23:21   ` Jason Uhlenkott
2007-08-15  7:28     ` Jan Engelhardt
2007-08-15  8:37       ` Rene Herman
2007-08-15  9:20         ` Jan Engelhardt
2007-08-15  9:43           ` Jason Uhlenkott
2007-08-15  9:58           ` Rene Herman
2007-08-15 10:20             ` Jan Engelhardt
2007-08-15 10:27               ` Rene Herman
2007-08-15 13:58               ` Kyle Moffett
2007-08-15 14:06                 ` Jan Engelhardt
2007-08-15 14:34                   ` Kyle Moffett
2007-08-15 16:01               ` H. Peter Anvin
2007-08-15  8:52       ` Jason Uhlenkott
2007-08-15  9:18       ` Andreas Schwab
2007-08-15  9:32       ` Giacomo A. Catenazzi
2007-08-14 23:42   ` Satyam Sharma
2007-08-15  0:19     ` Christoph Lameter
2007-08-17 18:22     ` Andrew Morton
2007-08-17 18:31       ` Arjan van de Ven [this message]
2007-08-17 18:50         ` Satyam Sharma
2007-08-17 18:37       ` Jan Engelhardt
2007-08-17 20:43       ` Christoph Lameter
2007-08-17 21:17         ` Satyam Sharma
2007-08-17 21:32           ` Satyam Sharma
2007-08-17 21:13       ` Satyam Sharma
2007-08-17 21:14         ` Christoph Lameter
2007-08-17 21:42           ` Pekka Enberg
2007-08-17 23:22             ` Christoph Lameter
2007-08-17 23:40             ` Thomas Gleixner
2007-08-18  0:02               ` Satyam Sharma
2007-08-18  1:03               ` Christoph Lameter
2007-08-18  8:10               ` Pekka Enberg
2007-08-18  8:21               ` Jan Engelhardt
2007-08-17 21:46           ` Satyam Sharma
2007-08-14 23:13 ` Satyam Sharma
     [not found] <fa.oMJ6o9vN0dnAoFR83/o4hg1EptE@ifi.uio.no>
2007-08-14 23:05 ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187375514.2615.0.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=satyam@infradead.org \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®