[2.6 patch] fix export_report.pl

[2.6 patch] fix export_report.pl

[Adrian Bunk]

This patch fixes an annoying bug of export_report.pl missing the usages 
of some exports.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 14 Aug 2007

--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
 			next;
 		}
 		if ($state eq 2) {
-			if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
+			if ( $_ !~ /0x[0-9a-f]+,/ ) {
 				next;
 			}
 			my $sym = (split /([,"])/,)[4];

Re: [2.6 patch] fix export_report.pl

[Jan Engelhardt]

On Aug 24 2007 23:04, Adrian Bunk wrote:
>This patch fixes an annoying bug of export_report.pl missing the usages 
>of some exports.
>
>Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
>---
>
>This patch has been sent on:
>- 14 Aug 2007
>
>--- a/scripts/export_report.pl
>+++ b/scripts/export_report.pl
>@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> 			next;
> 		}
> 		if ($state eq 2) {

Perl: == for numbers, eq for strings.
SH:   == for strings, -eq for numbers.
PHP:  == for everything.


>-			if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
>+			if ( $_ !~ /0x[0-9a-f]+,/ ) {

I have not looked closer at it, but this looks like it should be
/0x[0-9a-fA-F]+,/  or
/0x[0-9a-f]+,/i

> 				next;
> 			}
> 			my $sym = (split /([,"])/,)[4];
>

	Jan
-- 

Re: [2.6 patch] fix export_report.pl

[Adrian Bunk]

On Fri, Aug 24, 2007 at 11:36:40PM +0200, Jan Engelhardt wrote:
> 
> On Aug 24 2007 23:04, Adrian Bunk wrote:
> >This patch fixes an annoying bug of export_report.pl missing the usages 
> >of some exports.
> >
> >Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> >---
> >
> >This patch has been sent on:
> >- 14 Aug 2007
> >
> >--- a/scripts/export_report.pl
> >+++ b/scripts/export_report.pl
> >@@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
> > 			next;
> > 		}
> > 		if ($state eq 2) {
> 
> Perl: == for numbers, eq for strings.
> SH:   == for strings, -eq for numbers.
> PHP:  == for everything.

I don't care whether it compares strings or numbers as long as it 
works...

I'm not the author of this script, and my patch fixes the one annoying  
bug I observed when using it.

Feel free to improve the script, but that's unrelated to my bugfix.

> >-			if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
> >+			if ( $_ !~ /0x[0-9a-f]+,/ ) {
> 
> I have not looked closer at it, but this looks like it should be
> /0x[0-9a-fA-F]+,/  or
> /0x[0-9a-f]+,/i
>...

You should have looked closer before sending your email.

> 	Jan

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[2.6 patch] fix export_report.pl on top of adrian's fix

[Ram Pai]

Fixes some subtle perl coding bug observed 
by Jan Engelhardt <jengelh@computergmbh.de>
This patch applies on top of Adrian's fix.

Signed-off-by: Ram Pai <linuxram@us.ibm.com>

---
 scripts/export_report.pl |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6.21.5/scripts/export_report.pl
===================================================================
--- linux-2.6.21.5.orig/scripts/export_report.pl
+++ linux-2.6.21.5/scripts/export_report.pl
@@ -103,15 +103,15 @@ foreach my $thismod (@allcfiles) {
 	my $state=0;
 	while ( <MODULE_MODULE> ) {
 		chomp;
-		if ($state eq 0) {
+		if ($state == 0) {
 			$state = 1 if ($_ =~ /static const struct modversion_info/);
 			next;
 		}
-		if ($state eq 1) {
+		if ($state == 1) {
 			$state = 2 if ($_ =~ /__attribute__\(\(section\("__versions"\)\)\)/);
 			next;
 		}
-		if ($state eq 2) {
+		if ($state == 2) {
 			if ( $_ !~ /0x[0-9a-f]+,/ ) {
 				next;
 			}
@@ -121,7 +121,7 @@ foreach my $thismod (@allcfiles) {
 			push(@{$MODULE{$thismod}} , $sym);
 		}
 	}
-	if ($state ne 2) {
+	if ($state != 2) {
 		print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
 	}
 	close(MODULE_MODULE);

Re: [2.6 patch] fix export_report.pl

[Ram Pai]

On Fri, 2007-08-24 at 23:04 +0200, Adrian Bunk wrote:
> This patch fixes an annoying bug of export_report.pl missing the usages 
> of some exports.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
> This patch has been sent on:
> - 14 Aug 2007
> 
> --- a/scripts/export_report.pl
> +++ b/scripts/export_report.pl
> @@ -112,7 +112,7 @@ foreach my $thismod (@allcfiles) {
>  			next;
>  		}
>  		if ($state eq 2) {
> -			if ( $_ !~ /0x[0-9a-f]{7,8},/ ) {
> +			if ( $_ !~ /0x[0-9a-f]+,/ ) {
>  				next;
>  			}
>  			my $sym = (split /([,"])/,)[4];

Adrian,
      I am fine with these changes.

RP

Re: [2.6 patch] fix export_report.pl

[Sam Ravnborg]

On Fri, Aug 24, 2007 at 11:04:51PM +0200, Adrian Bunk wrote:
> This patch fixes an annoying bug of export_report.pl missing the usages 
> of some exports.
Applied to kbuild.git plus Ram Pai's patch too.

	Sam