* Redundent/missing code in dik_show_trace (arch/alpha/kernel/traps.c)
@ 2007-09-21 19:07 Gilboa Davara
0 siblings, 0 replies; only message in thread
From: Gilboa Davara @ 2007-09-21 19:07 UTC (permalink / raw)
To: linux-kernel
Hello all,
As the title suggest.
"i" is declared as 0 and never assigned a new value.
Down the code there's an if (i>40) and a certain dangling piece of code.
I assume that I should have gotten a string length (?) from somewhere?
Am I missing something?
- Gilboa
---
static void
dik_show_trace(unsigned long *sp)
{
long i = 0;
printk("Trace:\n");
while (0x1ff8 & (unsigned long) sp) {
extern char _stext[], _etext[];
unsigned long tmp = *sp;
sp++;
if (tmp < (unsigned long) &_stext)
continue;
if (tmp >= (unsigned long) &_etext)
continue;
printk("[<%lx>]", tmp);
print_symbol(" %s", tmp);
printk("\n");
if (i > 40) {
printk(" ...");
break;
}
}
printk("\n");
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-09-21 19:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-21 19:07 Redundent/missing code in dik_show_trace (arch/alpha/kernel/traps.c) Gilboa Davara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®