* [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr
@ 2007-09-26 15:41 bo yang
2007-09-28 20:45 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: bo yang @ 2007-09-26 15:41 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, akpm, linux-kernel, Bo.yang, Sumant.patro
MegaRAID utilities expect sense_buff to be of type unsigned long.
Signed-off-by: Bo Yang <bo.yang@lsi.com>
---
drivers/scsi/megaraid/megaraid_sas.c | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
diff -uprN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c
--- linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c 2007-09-27 04:41:39.000000000 -0700
+++ linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c 2007-09-27 04:50:14.000000000 -0700
@@ -2969,6 +2969,7 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
void *sense = NULL;
dma_addr_t sense_handle;
u32 *sense_ptr;
+ unsigned long *sense_buff;
memset(kbuff_arr, 0, sizeof(kbuff_arr));
@@ -3073,14 +3074,16 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
*/
if (ioc->sense_len) {
/*
- * sense_ptr points to the location that has the user
+ * sense_buff points to the location that has the user
* sense buffer address
*/
- sense_ptr = (u32 *) ((unsigned long)ioc->frame.raw +
- ioc->sense_off);
+ sense_buff = (unsigned long *) ((unsigned long)ioc->frame.raw +
+ ioc->sense_off);
- if (copy_to_user((void __user *)((unsigned long)(*sense_ptr)),
- sense, ioc->sense_len)) {
+ if (copy_to_user((void __user *)(unsigned long)(*sense_buff),
+ sense, ioc->sense_len)) {
+ printk(KERN_ERR "megasas: Failed to copy out to user"
+ "sense data\n");
error = -EFAULT;
goto out;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr
2007-09-26 15:41 [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr bo yang
@ 2007-09-28 20:45 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2007-09-28 20:45 UTC (permalink / raw)
To: bo yang
Cc: linux-scsi, James.Bottomley, akpm, linux-kernel, Bo.yang, Sumant.patro
On Wed, 26 Sep 2007 11:41:07 -0400 bo yang wrote:
> MegaRAID utilities expect sense_buff to be of type unsigned long.
>
> Signed-off-by: Bo Yang <bo.yang@lsi.com>
>
> ---
> drivers/scsi/megaraid/megaraid_sas.c | 13 ++++++++-----
> 1 files changed, 8 insertions(+), 5 deletions(-)
>
> diff -uprN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c
> --- linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c 2007-09-27 04:41:39.000000000 -0700
> +++ linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c 2007-09-27 04:50:14.000000000 -0700
> @@ -2969,6 +2969,7 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
> void *sense = NULL;
> dma_addr_t sense_handle;
> u32 *sense_ptr;
> + unsigned long *sense_buff;
>
> memset(kbuff_arr, 0, sizeof(kbuff_arr));
>
> @@ -3073,14 +3074,16 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
> */
> if (ioc->sense_len) {
> /*
> - * sense_ptr points to the location that has the user
> + * sense_buff points to the location that has the user
> * sense buffer address
> */
> - sense_ptr = (u32 *) ((unsigned long)ioc->frame.raw +
> - ioc->sense_off);
> + sense_buff = (unsigned long *) ((unsigned long)ioc->frame.raw +
> + ioc->sense_off);
>
> - if (copy_to_user((void __user *)((unsigned long)(*sense_ptr)),
> - sense, ioc->sense_len)) {
> + if (copy_to_user((void __user *)(unsigned long)(*sense_buff),
> + sense, ioc->sense_len)) {
> + printk(KERN_ERR "megasas: Failed to copy out to user"
> + "sense data\n");
" sense data\n");
> error = -EFAULT;
> goto out;
> }
---
~Randy
Phaedrus says that Quality is about caring.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr
@ 2007-10-01 16:02 bo yang
0 siblings, 0 replies; 3+ messages in thread
From: bo yang @ 2007-10-01 16:02 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, akpm, linux-kernel, Bo.yang, Sumant.patro
MegaRAID utilities expect sense_buff to be of type unsigned long.
Signed-off-by: Bo Yang <bo.yang@lsi.com>
---
drivers/scsi/megaraid/megaraid_sas.c | 13 ++++++++-----
1 files changed, 8 insertions(+), 5 deletions(-)
diff -uprN linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c
--- linux-2.6.22_orig/drivers/scsi/megaraid/megaraid_sas.c 2007-10-01 05:20:03.000000000 -0700
+++ linux-2.6.22_new/drivers/scsi/megaraid/megaraid_sas.c 2007-10-02 22:40:22.000000000 -0700
@@ -2942,6 +2942,7 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
void *sense = NULL;
dma_addr_t sense_handle;
u32 *sense_ptr;
+ unsigned long *sense_buff;
memset(kbuff_arr, 0, sizeof(kbuff_arr));
@@ -3046,14 +3047,16 @@ megasas_mgmt_fw_ioctl(struct megasas_ins
*/
if (ioc->sense_len) {
/*
- * sense_ptr points to the location that has the user
+ * sense_buff points to the location that has the user
* sense buffer address
*/
- sense_ptr = (u32 *) ((unsigned long)ioc->frame.raw +
- ioc->sense_off);
+ sense_buff = (unsigned long *) ((unsigned long)ioc->frame.raw +
+ ioc->sense_off);
- if (copy_to_user((void __user *)((unsigned long)(*sense_ptr)),
- sense, ioc->sense_len)) {
+ if (copy_to_user((void __user *)(unsigned long)(*sense_buff),
+ sense, ioc->sense_len)) {
+ printk(KERN_ERR "megasas: Failed to copy out to user "
+ "sense data\n");
error = -EFAULT;
goto out;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-03 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-26 15:41 [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr bo yang
2007-09-28 20:45 ` Randy Dunlap
2007-10-01 16:02 bo yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®