From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Shane <gnome42@gmail.com>
Cc: linux-kernel@vger.kernel.org,
video4linux-list <video4linux-list@redhat.com>,
Soeren Sonnenburg <kernel@nn7.de>
Subject: Re: 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!
Date: Wed, 12 Dec 2007 08:51:24 -0200 [thread overview]
Message-ID: <1197456684.4807.27.camel@gaivota> (raw)
In-Reply-To: <fa4052ef0712112120l1165af5btc108ea2131760328@mail.gmail.com>
Em Qua, 2007-12-12 às 00:20 -0500, Shane escreveu:
> In 2.6.24-rc5+, I hit this problem with videobuf_read_start
> not being exported. Patch attached, only compile tested.
>
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/linux/compile.h
> CC [M] drivers/media/video/videobuf-core.o
> Building modules, stage 2.
> Kernel: arch/x86/boot/bzImage is ready (#1)
> MODPOST 202 modules
> ERROR: "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
Thanks for reporting.
The patch is incomplete. I've just sent Linus the complete fix for this.
The issue here is that videobuf_read_start were replaced by
__videobuf_read_start, but mutex is missing at the last.
The patch I've just sent adds a mutex-safe version of
videobuf_read_start, adding the proper EXPORT_SYMBOL_GPL().
Cheers,
Mauro
prev parent reply other threads:[~2007-12-12 10:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:20 Shane
2007-12-12 9:07 ` Adrian Bunk
2007-12-12 11:03 ` Mauro Carvalho Chehab
2007-12-12 12:03 ` Adrian Bunk
2007-12-12 14:21 ` Mauro Carvalho Chehab
2007-12-12 16:37 ` Shane
2007-12-12 18:57 ` Shane
2007-12-12 19:44 ` [2.6 patch] videobuf-core.c locking fixes Adrian Bunk
2007-12-12 20:35 ` Shane
2007-12-12 21:22 ` Shane
2007-12-14 9:26 ` Mauro Carvalho Chehab
2007-12-13 9:59 ` Mauro Carvalho Chehab
2007-12-12 22:19 ` 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined! Jean Delvare
2007-12-13 10:33 ` Mauro Carvalho Chehab
2007-12-12 10:36 ` Soeren Sonnenburg
2007-12-12 10:51 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197456684.4807.27.camel@gaivota \
--to=mchehab@infradead.org \
--cc=gnome42@gmail.com \
--cc=kernel@nn7.de \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®