From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Shane <gnome42@gmail.com>, Brandon Philips <brandon@ifup.org>,
linux-kernel@vger.kernel.org,
video4linux-list <video4linux-list@redhat.com>
Subject: Re: 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined!
Date: Wed, 12 Dec 2007 09:03:14 -0200 [thread overview]
Message-ID: <1197457394.4807.40.camel@gaivota> (raw)
In-Reply-To: <20071212090709.GF14204@stusta.de>
> Any objections against a later path that changes the exports to the
> general "immediately after the function" convention?
No objections. Please generate against "devel" branch on my -git, since
I did a patch fixing most CodingStyle issues reported by checkpatch.pl.
Several files under /media still uses the old convention of having such
things at the end of the file.
> It would have avoided at least two such bugs in this file alone since
> 2.6.23...
I'm afraid that this wouldn't avoid this bug, however.
The removal of the EXPORT_SYMBOL_GPL seemed to be the intention of
Brandon, since he renamed the function, removing the locks. I think he
didn't noticed that videobuf_dvb were using videobuf_read_start. The
patch I've just send fixes it properly.
Btw, Shane patch reveals a small trouble with EXPORT_SYMBOL_GPL: adding
the tag for a non-existing function didn't rise any error. IMO, it
should generate some compilation error, if you try to export a symbol
that doesn't exist at the file that is being compiled.
Cheers,
Mauro
next prev parent reply other threads:[~2007-12-12 11:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:20 Shane
2007-12-12 9:07 ` Adrian Bunk
2007-12-12 11:03 ` Mauro Carvalho Chehab [this message]
2007-12-12 12:03 ` Adrian Bunk
2007-12-12 14:21 ` Mauro Carvalho Chehab
2007-12-12 16:37 ` Shane
2007-12-12 18:57 ` Shane
2007-12-12 19:44 ` [2.6 patch] videobuf-core.c locking fixes Adrian Bunk
2007-12-12 20:35 ` Shane
2007-12-12 21:22 ` Shane
2007-12-14 9:26 ` Mauro Carvalho Chehab
2007-12-13 9:59 ` Mauro Carvalho Chehab
2007-12-12 22:19 ` 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined! Jean Delvare
2007-12-13 10:33 ` Mauro Carvalho Chehab
2007-12-12 10:36 ` Soeren Sonnenburg
2007-12-12 10:51 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197457394.4807.40.camel@gaivota \
--to=mchehab@infradead.org \
--cc=brandon@ifup.org \
--cc=bunk@kernel.org \
--cc=gnome42@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome