[PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[Nicolas Mailhot]

Le jeudi 13 décembre 2007 à 21:38 -0800, Greg KH a écrit : 
> On Thu, Dec 13, 2007 at 11:37:40PM +0100, Nicolas Mailhot wrote:

> > The Gretag-Macbeth Huey display colorimeter claims to be an HID device
> > but isn't. As a result the linux HID device will claim it, preventing
> > FLOSS software like Argyll CMS (http://www.argyllcms.com/) from talking
> > to it,

> > Frédéric Crozat from Mandriva has such a device and may provide more
> > info.

> Care to make up a patch as per the Documentation/SubmittingPatches file
> and send it to this list and the HID driver maintainer?  That way you
> get the proper credit for this change.

The things I do as a public service, I don't even have the damn Huey
myself:(

There seems to be some complains about libusb BTW
(http://www.freelists.org/archives/argyllcms/12-2007/msg00068.html)


Signed-off-by: Nicolas Mailhot <nicolas.mailhot@laposte.net>

diff -uNr linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c
--- linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c	2007-12-11 04:48:43.000000000 +0100
+++ linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c	2007-12-14 10:41:01.000000000 +0100
@@ -85,6 +85,9 @@
 #define USB_VENDOR_ID_CHIC		0x05fe
 #define USB_DEVICE_ID_CHIC_GAMEPAD	0x0014
 
+#define USB_VENDOR_ID_GRETAGMACBETH	0x0971
+#define USB_DEVICE_ID_GRETAGMACBETH_HUEY	0x2005
+
 #define USB_VENDOR_ID_CIDC		0x1677
 
 #define USB_VENDOR_ID_CMEDIA		0x0d8c
@@ -423,6 +426,7 @@
 	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_SUPER_Q2, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_GOGOPEN, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_PENPOWER, HID_QUIRK_IGNORE },
+	{ USB_VENDOR_ID_GRETAGMACBETH, USB_DEVICE_ID_GRETAGMACBETH_HUEY, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_POWERMATE, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_SOUNDKNOB, HID_QUIRK_IGNORE },

-- 
Nicolas Mailhot

Re: [argyllcms] Re: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[Nicolas Mailhot]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]


Le vendredi 14 décembre 2007 à 22:46 +1100, Graeme Gill a écrit :
> Nicolas Mailhot wrote:
> 
> >>Care to make up a patch as per the Documentation/SubmittingPatches file
> >>and send it to this list and the HID driver maintainer?  That way you
> >>get the proper credit for this change.
> > 
> > The things I do as a public service, I don't even have the damn Huey
> > myself:(
> 
> Actually (to put it frankly), I'm amazed that this exceptions list is
> compiled into the driver. I would have thought that such a list should
> at least be in a configuration file that an installed application can
> add or delete, if not something more sophisticated.

Something more sophisticated will happen someday, this is what we have
now.

> What will happen if the
> HID driver is fixed to allow arbitrary messages, and I want to switch
> back to using it rather than libusb ?

Then the person doing the HID code fix should remove the blacklist entry
at the same time.

> And the question still remains as to why usb_detach_kernel_driver_np()
> works fine on some systems (ie. the one I'm testing on), and not (apparently)
> others.

I'm not saying it does not work, I'm saying I don't want my users to
fool with kernel modules when we know the default should not be HID for
huey right now. If you prefer enhancing the kernel HID driver, and
switching argyll to it, just do it. I don't care as long as I don't have
to maintain workarounds distro-side.

-- 
Nicolas Mailhot

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [argyllcms] Re: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[Jiri Kosina]

On Fri, 14 Dec 2007, Nicolas Mailhot wrote:

> > Actually (to put it frankly), I'm amazed that this exceptions list is 
> > compiled into the driver. I would have thought that such a list should 
> > at least be in a configuration file that an installed application can 
> > add or delete, if not something more sophisticated.
> Something more sophisticated will happen someday, this is what we have
> now.

There is also possibility (for quite a few releases already) to change the 
quirk list in runtime. See the 'quirk' parameter to the usbhid module.

> > What will happen if the HID driver is fixed to allow arbitrary 
> > messages, and I want to switch back to using it rather than libusb ?

What exactly is the problem here? I didn't seem to catch the beginning of 
the thread (or it happened off the list I am subscribed to).

I will apply the patch to my tree, thanks.

-- 
Jiri Kosina
SUSE Labs

Re: [argyllcms] Re: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[Nicolas Mailhot]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

[Replying twice because I replied to the wrong message at first]

Le dimanche 16 décembre 2007 à 17:59 +0100, Jiri Kosina a écrit :

> What exactly is the problem here? I didn't seem to catch the beginning of 
> the thread (or it happened off the list I am subscribed to).

For more info on usb colorimeter problems you can check
http://www.freelists.org/archives/argyllcms/12-2007/

It seems Graeme Gill, the Argyll CMS author has hit several linux usb
problems over the years but has not coordinated well with the Linux usb
maintainers. We're finding all the ugly bits now that we're trying to
meger Argyll CMS in various distributions (Fedora, Mandriva, Ubuntu,
etc)

It's a bit difficult to follow this thread because the argyllcms list is
killing CCs and not everyone is putting them back in.

Regards,

-- 
Nicolas Mailhot

[-- Attachment #2: Ceci est une partie de message numériquement signée --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] usb/hid: Blacklist the Gretag-Macbeth Huey display colorimeter

[Frederic Crozat]

Le vendredi 14 décembre 2007 à 11:04 +0100, Nicolas Mailhot a écrit :
> Le jeudi 13 décembre 2007 à 21:38 -0800, Greg KH a écrit : 
> > On Thu, Dec 13, 2007 at 11:37:40PM +0100, Nicolas Mailhot wrote:
> 
> > > The Gretag-Macbeth Huey display colorimeter claims to be an HID device
> > > but isn't. As a result the linux HID device will claim it, preventing
> > > FLOSS software like Argyll CMS (http://www.argyllcms.com/) from talking
> > > to it,
> 
> > > Frédéric Crozat from Mandriva has such a device and may provide more
> > > info.
> 
> > Care to make up a patch as per the Documentation/SubmittingPatches file
> > and send it to this list and the HID driver maintainer?  That way you
> > get the proper credit for this change.
> 
> The things I do as a public service, I don't even have the damn Huey
> myself:(
> 
> There seems to be some complains about libusb BTW
> (http://www.freelists.org/archives/argyllcms/12-2007/msg00068.html)
> 
> 
> Signed-off-by: Nicolas Mailhot <nicolas.mailhot@laposte.net>
> 
> diff -uNr linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c
> --- linux-2.6.24-rc5.orig/drivers/hid/usbhid/hid-quirks.c	2007-12-11 04:48:43.000000000 +0100
> +++ linux-2.6.24-rc5/drivers/hid/usbhid/hid-quirks.c	2007-12-14 10:41:01.000000000 +0100
> @@ -85,6 +85,9 @@
>  #define USB_VENDOR_ID_CHIC		0x05fe
>  #define USB_DEVICE_ID_CHIC_GAMEPAD	0x0014
>  
> +#define USB_VENDOR_ID_GRETAGMACBETH	0x0971
> +#define USB_DEVICE_ID_GRETAGMACBETH_HUEY	0x2005
> +
>  #define USB_VENDOR_ID_CIDC		0x1677
>  
>  #define USB_VENDOR_ID_CMEDIA		0x0d8c
> @@ -423,6 +426,7 @@
>  	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_SUPER_Q2, HID_QUIRK_IGNORE },
>  	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_GOGOPEN, HID_QUIRK_IGNORE },
>  	{ USB_VENDOR_ID_GOTOP, USB_DEVICE_ID_PENPOWER, HID_QUIRK_IGNORE },
> +	{ USB_VENDOR_ID_GRETAGMACBETH, USB_DEVICE_ID_GRETAGMACBETH_HUEY, HID_QUIRK_IGNORE },
>  	{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_POWERMATE, HID_QUIRK_IGNORE },
>  	{ USB_VENDOR_ID_GRIFFIN, USB_DEVICE_ID_SOUNDKNOB, HID_QUIRK_IGNORE },

Fixes the issue for me :

Tested-by: Frederic Crozat <fcrozat@mandriva.com>

-- 
Frederic Crozat <fcrozat@mandriva.com>
Mandriva