From: YanBo <dreamfly281@gmail.com>
To: "Julia Lawall" <julia@diku.dk>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/3] drivers/staging/agnx: Move a dereference below a NULL test
Date: Mon, 22 Dec 2008 10:10:17 +0800 [thread overview]
Message-ID: <1197ff4c0812211810s796a367m7b5dc6b43724c0e0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812191810240.11217@ask.diku.dk>
On Sat, Dec 20, 2008 at 1:11 AM, Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
>
> - T i = E->fld;
> + T i;
> ... when != E
> when != i
> if (E == NULL) S
> + i = E->fld;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/staging/agnx/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -u -p a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
> --- a/drivers/staging/agnx/pci.c
> +++ b/drivers/staging/agnx/pci.c
> @@ -440,11 +440,12 @@ static struct ieee80211_ops agnx_ops = {
> static void __devexit agnx_pci_remove(struct pci_dev *pdev)
> {
> struct ieee80211_hw *dev = pci_get_drvdata(pdev);
> - struct agnx_priv *priv = dev->priv;
> + struct agnx_priv *priv;
> AGNX_TRACE;
>
> if (!dev)
> return;
> + priv = dev->priv;
> ieee80211_unregister_hw(dev);
> pci_iounmap(pdev, priv->ctl);
> pci_iounmap(pdev, priv->data);
>
Thanks! Will pulled to the AGNX git tree.
BR
Yanbo
prev parent reply other threads:[~2008-12-22 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 17:11 Julia Lawall
2008-12-22 2:10 ` YanBo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197ff4c0812211810s796a367m7b5dc6b43724c0e0@mail.gmail.com \
--to=dreamfly281@gmail.com \
--cc=gregkh@suse.de \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®