mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/3] drivers/staging/agnx: Move a dereference below a NULL test
@ 2008-12-19 17:11 Julia Lawall
  2008-12-22  2:10 ` YanBo
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-12-19 17:11 UTC (permalink / raw)
  To: dreamfly281, gregkh, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 drivers/staging/agnx/pci.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -u -p a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
--- a/drivers/staging/agnx/pci.c
+++ b/drivers/staging/agnx/pci.c
@@ -440,11 +440,12 @@ static struct ieee80211_ops agnx_ops = {
 static void __devexit agnx_pci_remove(struct pci_dev *pdev)
 {
 	struct ieee80211_hw *dev = pci_get_drvdata(pdev);
-	struct agnx_priv *priv = dev->priv;
+	struct agnx_priv *priv;
 	AGNX_TRACE;
 
 	if (!dev)
 		return;
+	priv = dev->priv;
 	ieee80211_unregister_hw(dev);
 	pci_iounmap(pdev, priv->ctl);
 	pci_iounmap(pdev, priv->data);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/3] drivers/staging/agnx: Move a dereference below a NULL test
  2008-12-19 17:11 [PATCH 2/3] drivers/staging/agnx: Move a dereference below a NULL test Julia Lawall
@ 2008-12-22  2:10 ` YanBo
  0 siblings, 0 replies; 2+ messages in thread
From: YanBo @ 2008-12-22  2:10 UTC (permalink / raw)
  To: Julia Lawall; +Cc: gregkh, linux-kernel, kernel-janitors

On Sat, Dec 20, 2008 at 1:11 AM, Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> If the NULL test is necessary, then the dereference should be moved below
> the NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
>
> - T i = E->fld;
> + T i;
>  ... when != E
>      when != i
>  if (E == NULL) S
> + i = E->fld;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
>  drivers/staging/agnx/pci.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -u -p a/drivers/staging/agnx/pci.c b/drivers/staging/agnx/pci.c
> --- a/drivers/staging/agnx/pci.c
> +++ b/drivers/staging/agnx/pci.c
> @@ -440,11 +440,12 @@ static struct ieee80211_ops agnx_ops = {
>  static void __devexit agnx_pci_remove(struct pci_dev *pdev)
>  {
>        struct ieee80211_hw *dev = pci_get_drvdata(pdev);
> -       struct agnx_priv *priv = dev->priv;
> +       struct agnx_priv *priv;
>        AGNX_TRACE;
>
>        if (!dev)
>                return;
> +       priv = dev->priv;
>        ieee80211_unregister_hw(dev);
>        pci_iounmap(pdev, priv->ctl);
>        pci_iounmap(pdev, priv->data);
>

Thanks! Will pulled to the AGNX git tree.

BR
Yanbo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-12-22  2:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-19 17:11 [PATCH 2/3] drivers/staging/agnx: Move a dereference below a NULL test Julia Lawall
2008-12-22  2:10 ` YanBo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®