From: David Dillow <dave@thedillows.org>
To: FUJITA Tomonori <tomof@acm.org>
Cc: fujita.tomonori@lab.ntt.co.jp, rdreier@cisco.com,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [ofa-general] Re: list corruption on ib_srp load in v2.6.24-rc5
Date: Thu, 03 Jan 2008 15:51:25 -0500 [thread overview]
Message-ID: <1199393485.7561.51.camel@lap75545.ornl.gov> (raw)
In-Reply-To: <1199390957.7561.33.camel@lap75545.ornl.gov>
On Thu, 2008-01-03 at 15:09 -0500, David Dillow wrote:
> As for a better fix, I'm not sure.
Here's a better way than the strncmp. If this meets everyone's approval,
then I can roll up a proper commit.
diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c
index 44a340b..65c584d 100644
--- a/drivers/scsi/scsi_transport_srp.c
+++ b/drivers/scsi/scsi_transport_srp.c
@@ -265,7 +265,8 @@ EXPORT_SYMBOL_GPL(srp_rport_del);
static int do_srp_rport_del(struct device *dev, void *data)
{
- srp_rport_del(dev_to_rport(dev));
+ if (scsi_is_srp_rport(dev))
+ srp_rport_del(dev_to_rport(dev));
return 0;
}
next prev parent reply other threads:[~2008-01-03 20:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 21:52 David Dillow
2007-12-21 21:54 ` David Dillow
2007-12-21 22:18 ` David Dillow
2007-12-22 15:15 ` [ofa-general] " Pete Wyckoff
2007-12-22 16:41 ` FUJITA Tomonori
2007-12-22 17:32 ` Dave Dillow
2007-12-26 17:14 ` David Dillow
2007-12-27 2:58 ` FUJITA Tomonori
2007-12-27 17:53 ` David Dillow
2008-01-02 17:51 ` Roland Dreier
2008-01-03 8:30 ` FUJITA Tomonori
2008-01-03 20:09 ` [ofa-general] " David Dillow
2008-01-03 20:51 ` David Dillow [this message]
2008-01-03 21:33 ` Roland Dreier
2008-01-04 0:47 ` FUJITA Tomonori
2008-01-04 2:34 ` [2.6.24-rc BUGFIX] SRP transport: only remove our own entries Dave Dillow
2008-01-04 2:54 ` FUJITA Tomonori
2008-01-04 2:39 ` [2.6.24-rc BUGFIX] IB/srp: release transport when removing host Dave Dillow
2008-01-04 2:54 ` FUJITA Tomonori
2008-01-04 3:35 ` [2.6.24-rc minor bugfix] IB/srp: release transport before " Dave Dillow
2008-01-08 20:09 ` Roland Dreier
2007-12-21 22:21 ` [ofa-general] list corruption on ib_srp load in v2.6.24-rc5 Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199393485.7561.51.camel@lap75545.ornl.gov \
--to=dave@thedillows.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®