mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: David Dillow <dillowda@ornl.gov>
Cc: linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [ofa-general] list corruption on ib_srp load in v2.6.24-rc5
Date: Fri, 21 Dec 2007 14:21:09 -0800	[thread overview]
Message-ID: <adabq8jy9ii.fsf@cisco.com> (raw)
In-Reply-To: <1198273973.9979.34.camel@lap75545.ornl.gov> (David Dillow's message of "Fri, 21 Dec 2007 16:52:53 -0500")

 > I'm getting the following oops when doing the following commands:
 > 
 > modprobe ib_srp
 > <add targets(s) to ib_srp using sysfs>
 > rmmod ib_srp
 > modprobe ib_srp
 > <OOPS>
 > 
 > I'm going to try and track down how the list is getting corrupted; it
 > looks like attribute_container_list in
 > drivers/base/attribute_container.c is the one getting corrupted.
 > 
 > Before I get too far into this, has anyone seen this one before? I
 > looked at 'git diff v2.6.24-rc4..' and didn't see any changes that would
 > stand out as fixing it.

I haven't seen this, but I actually haven't done much srp testing with
post-2.6.23 kernels.  From a quick skim through the code, I would
guess that one of the calls to transport_container_unregister() in
srp_release_transport() (which is called one module unload) is
failing and leaving something bogus on the attribute_container_list.

This could because the underlying call to attribute_container_unregister()
fails because the k_list is not empty.  I don't know if this is some
sort of leak in the ib_srp driver, or something broken elsewhere...

 - R.

      parent reply	other threads:[~2007-12-21 22:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-21 21:52 David Dillow
2007-12-21 21:54 ` David Dillow
2007-12-21 22:18 ` David Dillow
2007-12-22 15:15   ` [ofa-general] " Pete Wyckoff
2007-12-22 16:41   ` FUJITA Tomonori
2007-12-22 17:32     ` Dave Dillow
2007-12-26 17:14     ` David Dillow
2007-12-27  2:58       ` FUJITA Tomonori
2007-12-27 17:53         ` David Dillow
2008-01-02 17:51       ` Roland Dreier
2008-01-03  8:30         ` FUJITA Tomonori
2008-01-03 20:09           ` [ofa-general] " David Dillow
2008-01-03 20:51             ` David Dillow
2008-01-03 21:33               ` Roland Dreier
2008-01-04  0:47               ` FUJITA Tomonori
2008-01-04  2:34                 ` [2.6.24-rc BUGFIX] SRP transport: only remove our own entries Dave Dillow
2008-01-04  2:54                   ` FUJITA Tomonori
2008-01-04  2:39                 ` [2.6.24-rc BUGFIX] IB/srp: release transport when removing host Dave Dillow
2008-01-04  2:54                   ` FUJITA Tomonori
2008-01-04  3:35                     ` [2.6.24-rc minor bugfix] IB/srp: release transport before " Dave Dillow
2008-01-08 20:09                       ` Roland Dreier
2007-12-21 22:21 ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adabq8jy9ii.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=dillowda@ornl.gov \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome