From: marcin.slusarz@gmail.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: [PATCH] udf: check if udf_load_logicalvol failed
Date: Sun, 6 Jan 2008 01:44:33 +0100 [thread overview]
Message-ID: <1199580275-2487-5-git-send-email-marcin.slusarz@gmail.com> (raw)
In-Reply-To: <1199580275-2487-1-git-send-email-marcin.slusarz@gmail.com>
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
CC: Ben Fennema <bfennema@falcon.csc.calpoly.edu>
CC: Jan Kara <jack@suse.cz>
CC: Christoph Hellwig <hch@infradead.org>
---
fs/udf/super.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/fs/udf/super.c b/fs/udf/super.c
index 3f5b632..c09e968 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1188,6 +1188,7 @@ static int udf_process_sequence(struct super_block *sb, long block,
uint32_t vdsn;
uint16_t ident;
long next_s = 0, next_e = 0;
+ int ret;
memset(vds, 0, sizeof(struct udf_vds_record) * VDS_POS_LENGTH);
@@ -1263,7 +1264,11 @@ static int udf_process_sequence(struct super_block *sb, long block,
if (i == VDS_POS_PRIMARY_VOL_DESC) {
udf_load_pvoldesc(sb, bh);
} else if (i == VDS_POS_LOGICAL_VOL_DESC) {
- udf_load_logicalvol(sb, bh, fileset); /* TODO: check return value */
+ ret = udf_load_logicalvol(sb, bh, fileset);
+ if (ret != 0) {
+ brelse(bh);
+ return ret;
+ }
} else if (i == VDS_POS_PARTITION_DESC) {
struct buffer_head *bh2 = NULL;
if (udf_load_partdesc(sb, bh)) {
--
1.5.3.7
next prev parent reply other threads:[~2008-01-06 0:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 0:44 [PATCH 0/6] udf: improve code related to super_block v3 marcin.slusarz
2008-01-06 0:44 ` [PATCH] udf: fix coding style of super.c marcin.slusarz
2008-01-07 13:33 ` Jan Kara
2008-01-06 0:44 ` [PATCH] udf: remove some ugly macros marcin.slusarz
2008-01-06 0:44 ` [PATCH] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function marcin.slusarz
2008-01-06 0:44 ` marcin.slusarz [this message]
2008-01-07 12:19 ` [PATCH] udf: check if udf_load_logicalvol failed Christoph Hellwig
2008-01-06 0:44 ` [PATCH] udf: convert some macros to functions marcin.slusarz
2008-01-07 12:26 ` Christoph Hellwig
2008-01-07 20:44 ` Marcin Slusarz
2008-01-07 23:28 ` Andrew Morton
2008-01-08 6:52 ` Marcin Slusarz
2008-01-08 10:09 ` Jan Kara
2008-01-06 0:44 ` [PATCH] udf: fix sparse warnings (shadowing & mismatch between declaration and definition) marcin.slusarz
2008-01-07 12:26 ` Christoph Hellwig
2008-01-06 0:52 ` [PATCH 0/6] udf: improve code related to super_block v3 Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199580275-2487-5-git-send-email-marcin.slusarz@gmail.com \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome