From: Christoph Hellwig <hch@infradead.org>
To: marcin.slusarz@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] udf: check if udf_load_logicalvol failed
Date: Mon, 7 Jan 2008 12:19:50 +0000 [thread overview]
Message-ID: <20080107121950.GA3710@infradead.org> (raw)
In-Reply-To: <1199580275-2487-5-git-send-email-marcin.slusarz@gmail.com>
On Sun, Jan 06, 2008 at 01:44:33AM +0100, marcin.slusarz@gmail.com wrote:
> + ret = udf_load_logicalvol(sb, bh, fileset);
> + if (ret != 0) {
> + brelse(bh);
> + return ret;
> + }
This would be a simple if (ret) in normal Linux style if I'd want to
be picky, but the actual change look good.
next prev parent reply other threads:[~2008-01-07 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 0:44 [PATCH 0/6] udf: improve code related to super_block v3 marcin.slusarz
2008-01-06 0:44 ` [PATCH] udf: fix coding style of super.c marcin.slusarz
2008-01-07 13:33 ` Jan Kara
2008-01-06 0:44 ` [PATCH] udf: remove some ugly macros marcin.slusarz
2008-01-06 0:44 ` [PATCH] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function marcin.slusarz
2008-01-06 0:44 ` [PATCH] udf: check if udf_load_logicalvol failed marcin.slusarz
2008-01-07 12:19 ` Christoph Hellwig [this message]
2008-01-06 0:44 ` [PATCH] udf: convert some macros to functions marcin.slusarz
2008-01-07 12:26 ` Christoph Hellwig
2008-01-07 20:44 ` Marcin Slusarz
2008-01-07 23:28 ` Andrew Morton
2008-01-08 6:52 ` Marcin Slusarz
2008-01-08 10:09 ` Jan Kara
2008-01-06 0:44 ` [PATCH] udf: fix sparse warnings (shadowing & mismatch between declaration and definition) marcin.slusarz
2008-01-07 12:26 ` Christoph Hellwig
2008-01-06 0:52 ` [PATCH 0/6] udf: improve code related to super_block v3 Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080107121950.GA3710@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome