From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "jack.zhu" <jack.zhu@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, changhuang.liang@starfivetech.com
Subject: Re: [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent
Date: Fri, 3 Mar 2023 09:47:54 +0100 [thread overview]
Message-ID: <11e7c986-e6cc-ee57-b36e-816af8cc11a7@linaro.org> (raw)
In-Reply-To: <20230302091921.43309-3-jack.zhu@starfivetech.com>
On 02/03/2023 10:19, jack.zhu wrote:
> Add DT binding document for Starfive MIPI CSI2 receiver
Ehh... you have entire commit msg to explain what you do here. Yet there
is nothing mentioning that you actually have Cadence MIPI CSI here.
Since you decided to add new bindings, you receive review matching new
bindings. I don't think this is correct approach (duplicated bindings),
but could work for me. However how are you going to solve all the points
of my review?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-03 8:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230302091921.43309-1-jack.zhu@starfivetech.com>
[not found] ` <20230302091921.43309-2-jack.zhu@starfivetech.com>
2023-03-03 8:34 ` [PATCH v1 01/11] media: dt-bindings: starfive,jh7110-camss: add binding document Krzysztof Kozlowski
2023-03-07 6:20 ` Jack Zhu
2023-03-03 8:35 ` Krzysztof Kozlowski
2023-03-07 6:35 ` Jack Zhu
[not found] ` <20230302091921.43309-5-jack.zhu@starfivetech.com>
2023-03-03 8:42 ` [PATCH v1 04/11] MAINTAINERS: add Starfive Camera subsystem driver Krzysztof Kozlowski
2023-03-09 2:52 ` Jack Zhu
[not found] ` <20230302091921.43309-12-jack.zhu@starfivetech.com>
2023-03-03 8:43 ` [PATCH v1 11/11] media: starfive: enable building Krzysztof Kozlowski
2023-03-07 9:46 ` Jack Zhu
2023-03-08 10:33 ` Krzysztof Kozlowski
2023-03-08 11:03 ` Jack Zhu
2023-03-08 11:07 ` Krzysztof Kozlowski
2023-03-09 2:13 ` Jack Zhu
[not found] ` <20230302091921.43309-11-jack.zhu@starfivetech.com>
2023-03-03 8:44 ` [PATCH v1 10/11] media: uapi: add user space interfaces Krzysztof Kozlowski
2023-03-09 2:22 ` Jack Zhu
[not found] ` <20230302091921.43309-7-jack.zhu@starfivetech.com>
2023-03-03 8:45 ` [PATCH v1 06/11] media: starfive: add ISP driver files Krzysztof Kozlowski
2023-03-07 9:53 ` Jack Zhu
2023-03-08 10:34 ` Krzysztof Kozlowski
2023-03-08 11:04 ` Jack Zhu
[not found] ` <20230302091921.43309-3-jack.zhu@starfivetech.com>
2023-03-03 8:42 ` [PATCH v1 02/11] media: dt-bindings: starfive,jh7110-mipi-csi2: add binding docmuent Krzysztof Kozlowski
2023-03-03 8:47 ` Krzysztof Kozlowski [this message]
2023-03-07 6:41 ` Jack Zhu
2023-03-07 7:53 ` Krzysztof Kozlowski
2023-03-07 10:08 ` Jack Zhu
2023-03-08 10:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11e7c986-e6cc-ee57-b36e-816af8cc11a7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=changhuang.liang@starfivetech.com \
--cc=devicetree@vger.kernel.org \
--cc=jack.zhu@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®