From: Borislav Petkov <bbpetkov@yahoo.de>
To: Bartlomiej@gollum.tnic, Zolnierkiewicz@gollum.tnic, <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Borislav Petkov <bbpetkov@yahoo.de>
Subject: [PATCH 03/21] ide-floppy: remove unnecessary ->handler != NULL check
Date: Fri, 11 Jan 2008 12:58:01 +0100 [thread overview]
Message-ID: <1200052699-28420-4-git-send-email-bbpetkov@yahoo.de> (raw)
In-Reply-To: <1200052699-28420-3-git-send-email-bbpetkov@yahoo.de>
This BUG_ON is unneeded since the ->handler != NULL check is performed in
ide_set_handler().
Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
---
drivers/ide/ide-floppy.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e63758a..66dfd18 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
@@ -794,7 +794,7 @@ static ide_startstop_t idefloppy_pc_intr (ide_drive_t *drive)
"to send us more data than expected "
"- discarding data\n");
idefloppy_discard_data(drive, bcount);
- BUG_ON(HWGROUP(drive)->handler != NULL);
+
ide_set_handler(drive,
&idefloppy_pc_intr,
IDEFLOPPY_WAIT_CMD,
@@ -825,7 +825,6 @@ static ide_startstop_t idefloppy_pc_intr (ide_drive_t *drive)
pc->actually_transferred += bcount;
pc->current_position += bcount;
- BUG_ON(HWGROUP(drive)->handler != NULL);
ide_set_handler(drive, &idefloppy_pc_intr, IDEFLOPPY_WAIT_CMD, NULL); /* And set the interrupt handler again */
return ide_started;
}
@@ -852,7 +851,7 @@ static ide_startstop_t idefloppy_transfer_pc (ide_drive_t *drive)
"issuing a packet command\n");
return ide_do_reset(drive);
}
- BUG_ON(HWGROUP(drive)->handler != NULL);
+
/* Set the interrupt routine */
ide_set_handler(drive, &idefloppy_pc_intr, IDEFLOPPY_WAIT_CMD, NULL);
/* Send the actual packet */
@@ -908,7 +907,7 @@ static ide_startstop_t idefloppy_transfer_pc1 (ide_drive_t *drive)
* 40 and 50msec work well. idefloppy_pc_intr will not be actually
* used until after the packet is moved in about 50 msec.
*/
- BUG_ON(HWGROUP(drive)->handler != NULL);
+
ide_set_handler(drive,
&idefloppy_pc_intr, /* service routine for packet command */
floppy->ticks, /* wait this long before "failing" */
--
1.5.3.7
next prev parent reply other threads:[~2008-01-11 12:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 11:57 [PATCH 00/21] ide-floppy redux v2 Borislav Petkov
2008-01-11 11:57 ` [PATCH 01/21] ide-floppy: convert to generic packet commands Borislav Petkov
2008-01-11 11:58 ` [PATCH 02/21] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov [this message]
2008-01-11 11:58 ` [PATCH 04/21] ide-floppy: cleanup and unify debugging macro calls Borislav Petkov
2008-01-11 11:58 ` [PATCH 05/21] ide-floppy: remove struct idefloppy_capabilities_page Borislav Petkov
2008-01-11 11:58 ` [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page Borislav Petkov
2008-01-11 11:58 ` [PATCH 07/21] ide-floppy: remove struct idefloppy_capacity_descriptor Borislav Petkov
2008-01-11 11:58 ` [PATCH 08/21] ide-floppy: remove struct idefloppy_inquiry_result Borislav Petkov
2008-01-11 11:58 ` [PATCH 09/21] ide-floppy: remove struct idefloppy_request_sense_result Borislav Petkov
2008-01-11 11:58 ` [PATCH 10/21] ide-floppy: remove struct idefloppy_mode_parameter_header Borislav Petkov
2008-01-11 11:58 ` [PATCH 11/21] ide-floppy: fix comments formatting Borislav Petkov
2008-01-11 11:58 ` [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Borislav Petkov
[not found] ` <1200052699-28420-14-git-send-email-bbpetkov@yahoo.de>
2008-01-11 11:58 ` [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error Borislav Petkov
2008-01-11 11:58 ` [PATCH 15/21] ide-floppy: disambiguate function names Borislav Petkov
[not found] ` <1200052699-28420-17-git-send-email-bbpetkov@yahoo.de>
[not found] ` <1200052699-28420-18-git-send-email-bbpetkov@yahoo.de>
2008-01-11 11:58 ` [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe() Borislav Petkov
2008-01-11 11:58 ` [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues Borislav Petkov
2008-01-11 11:58 ` [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers Borislav Petkov
2008-01-11 11:58 ` [PATCH 21/21] ide-floppy: remove atomic test_*bit macros Borislav Petkov
2008-01-12 20:19 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:19 ` [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers Bartlomiej Zolnierkiewicz
2008-01-12 20:18 ` [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues Bartlomiej Zolnierkiewicz
2008-01-12 20:18 ` [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe() Bartlomiej Zolnierkiewicz
2008-01-12 21:12 ` Borislav Petkov
2008-01-12 20:16 ` [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error Bartlomiej Zolnierkiewicz
2008-01-12 20:16 ` [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Bartlomiej Zolnierkiewicz
2008-01-12 20:16 ` [PATCH 11/21] ide-floppy: fix comments formatting Bartlomiej Zolnierkiewicz
2008-01-12 0:59 ` [PATCH 07/21] ide-floppy: remove struct idefloppy_capacity_descriptor Bartlomiej Zolnierkiewicz
2008-01-12 0:58 ` [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page Bartlomiej Zolnierkiewicz
2008-01-12 20:15 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:38 ` Borislav Petkov
2008-01-12 21:32 ` Bartlomiej Zolnierkiewicz
2008-01-11 23:56 ` [PATCH 04/21] ide-floppy: cleanup and unify debugging macro calls Bartlomiej Zolnierkiewicz
2008-01-12 13:46 ` [PATCH 00/21] ide-floppy redux v2 Bartlomiej Zolnierkiewicz
2008-01-12 20:14 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:51 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200052699-28420-4-git-send-email-bbpetkov@yahoo.de \
--to=bbpetkov@yahoo.de \
--cc=Bartlomiej@gollum.tnic \
--cc=Zolnierkiewicz@gollum.tnic \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome