From: Zachary Amsden <zach@vmware.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8390: split up 8390 with ISA delay and 8390 without
Date: Fri, 11 Jan 2008 15:16:31 -0800 [thread overview]
Message-ID: <1200093391.21817.27.camel@bodhitayantram.eng.vmware.com> (raw)
In-Reply-To: <20080111180848.10a7f012@lxorguk.ukuu.org.uk>
On Fri, 2008-01-11 at 18:08 +0000, Alan Cox wrote:
> This lets us remove port 0x80 use on the PCI systems. It also speeds
> up
> some of the later 8390 based cores where we know the device does not
> need
> delay loops either because it has internal handling or in most cases a
> faster device anyway.
>
> We compile up a new module 8390p to go with 8390 one with delays and
> one
> without. Most users will never need 8390p so it seems best to produce
> two
> modules.
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c linux-2.6.24-rc6-mm1/drivers/net/hp.c
> --- linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-02 16:04:00.000000000 +0000
> +++ linux-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-11 14:47:44.000000000 +0000
> @@ -176,7 +176,7 @@
> outb_p(irqmap[irq] | HP_RUN, ioaddr + HP_CONFIGURE);
> outb_p( 0x00 | HP_RUN, ioaddr + HP_CONFIGURE);
... didn't you miss two here? Otherwise, code looks great.
How will the user know when they need to use 8390p? Should you perhaps default to producing and using 8390p if CONFIG_ISA is on?
Zach
next prev parent reply other threads:[~2008-01-11 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 18:08 Alan Cox
2008-01-11 23:16 ` Zachary Amsden [this message]
2008-01-12 0:17 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200093391.21817.27.camel@bodhitayantram.eng.vmware.com \
--to=zach@vmware.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®