From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Zachary Amsden <zach@vmware.com>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8390: split up 8390 with ISA delay and 8390 without
Date: Sat, 12 Jan 2008 00:17:11 +0000 [thread overview]
Message-ID: <20080112001711.08361cd8@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1200093391.21817.27.camel@bodhitayantram.eng.vmware.com>
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c linux-2.6.24-rc6-mm1/drivers/net/hp.c
> > --- linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-02 16:04:00.000000000 +0000
> > +++ linux-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-11 14:47:44.000000000 +0000
>
> > @@ -176,7 +176,7 @@
> > outb_p(irqmap[irq] | HP_RUN, ioaddr + HP_CONFIGURE);
> > outb_p( 0x00 | HP_RUN, ioaddr + HP_CONFIGURE);
>
> ... didn't you miss two here? Otherwise, code looks great.
The patch only changes the _p usage within the shared library. The hp.c
code is used solely by the ISA HP driver and needed.
> How will the user know when they need to use 8390p?
They don't need to, any more than they need to know about 8390 right now.
It is added to the Makefile so will be sucked in and built by Make as an
extra module. The 8390p and 8390 use different wrapper symbols for
ei_open etc so depmod will load the right one.
Alan
prev parent reply other threads:[~2008-01-12 0:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 18:08 Alan Cox
2008-01-11 23:16 ` Zachary Amsden
2008-01-12 0:17 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112001711.08361cd8@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®