From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] x86: fix section mismatch warning in mcheck/mce_64.c
Date: Sat, 26 Jan 2008 23:11:47 +0100 [thread overview]
Message-ID: <1201385513-26885-2-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080126215917.GB26651@uranus.ravnborg.org>
Fix following warning:
WARNING: arch/x86/kernel/cpu/mcheck/built-in.o(.text+0x752): Section mismatch: reference to .cpuinit.text:mce_create_device in 'mce_cpu_callback'
mce_cpu_callback() is only used by mce_cpu_notofier.
The notifier is only used for hotplugable cpu's as it is
registered using register_hotcpu_notifier(),
Annotate them both __cpuinit to fix the warning.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
arch/x86/kernel/cpu/mcheck/mce_64.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce_64.c b/arch/x86/kernel/cpu/mcheck/mce_64.c
index 98b23d5..9a699ed 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_64.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_64.c
@@ -854,8 +854,8 @@ static void mce_remove_device(unsigned int cpu)
}
/* Get notified when a cpu comes on/off. Be hotplug friendly. */
-static int
-mce_cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
+static int __cpuinit mce_cpu_callback(struct notifier_block *nfb,
+ unsigned long action, void *hcpu)
{
unsigned int cpu = (unsigned long)hcpu;
@@ -872,7 +872,7 @@ mce_cpu_callback(struct notifier_block *nfb, unsigned long action, void *hcpu)
return NOTIFY_OK;
}
-static struct notifier_block mce_cpu_notifier = {
+static struct notifier_block mce_cpu_notifier __cpuinitdata = {
.notifier_call = mce_cpu_callback,
};
--
1.5.4.rc3.14.g44397
next prev parent reply other threads:[~2008-01-26 22:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-26 21:59 [PATCH 0/8] x86: fix section mismatch warnings Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in srat_64.c Sam Ravnborg
2008-01-26 22:11 ` Sam Ravnborg [this message]
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in mcheck/mce_amd_64.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in topology.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in process_*.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in acpi/boot.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in early-quirks.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in setup_64.c Sam Ravnborg
2008-01-28 10:09 ` [PATCH 0/8] x86: fix section mismatch warnings Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201385513-26885-2-git-send-email-sam@ravnborg.org \
--to=sam@ravnborg.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome