mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Ingo Molnar <mingo@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] x86: fix section mismatch warning in acpi/boot.c
Date: Sat, 26 Jan 2008 23:11:51 +0100	[thread overview]
Message-ID: <1201385513-26885-6-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080126215917.GB26651@uranus.ravnborg.org>

Fix following warning:
WARNING: arch/x86/kernel/built-in.o(.text+0x10ea0): Section mismatch: reference to .cpuinit.data:num_processors in 'acpi_unmap_lsapic'

The exported function acpi_unmap_lsapic() references
the variable num_processors that is annotated __cpuinitdata.

Remove the annotation of num_processors as we never know
when an exported function are called.
And drop the needless initialsation to 0.

Warning was seen on 64 bit but similar pattern were seen
in 32 bit - so fix it up there too.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 arch/x86/kernel/mpparse_32.c |    2 +-
 arch/x86/kernel/mpparse_64.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/mpparse_32.c b/arch/x86/kernel/mpparse_32.c
index cc06eae..67009cd 100644
--- a/arch/x86/kernel/mpparse_32.c
+++ b/arch/x86/kernel/mpparse_32.c
@@ -68,7 +68,7 @@ unsigned int def_to_bigsmp = 0;
 /* Processor that is doing the boot up */
 unsigned int boot_cpu_physical_apicid = -1U;
 /* Internal processor count */
-unsigned int __cpuinitdata num_processors;
+unsigned int num_processors;
 
 /* Bitmask of physically existing CPUs */
 physid_mask_t phys_cpu_present_map;
diff --git a/arch/x86/kernel/mpparse_64.c b/arch/x86/kernel/mpparse_64.c
index d3260f8..72ab140 100644
--- a/arch/x86/kernel/mpparse_64.c
+++ b/arch/x86/kernel/mpparse_64.c
@@ -60,7 +60,7 @@ unsigned int boot_cpu_id = -1U;
 EXPORT_SYMBOL(boot_cpu_id);
 
 /* Internal processor count */
-unsigned int num_processors __cpuinitdata = 0;
+unsigned int num_processors;
 
 unsigned disabled_cpus __cpuinitdata;
 
-- 
1.5.4.rc3.14.g44397


  parent reply	other threads:[~2008-01-26 22:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26 21:59 [PATCH 0/8] x86: fix section mismatch warnings Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in srat_64.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in mcheck/mce_64.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in mcheck/mce_amd_64.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in topology.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in process_*.c Sam Ravnborg
2008-01-26 22:11 ` Sam Ravnborg [this message]
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in early-quirks.c Sam Ravnborg
2008-01-26 22:11 ` [PATCH] x86: fix section mismatch warning in setup_64.c Sam Ravnborg
2008-01-28 10:09 ` [PATCH 0/8] x86: fix section mismatch warnings Ingo Molnar
2008-01-31 22:04 [PATCH 0/11] fix 25 " Sam Ravnborg
2008-01-31 22:10 ` [PATCH] x86: fix section mismatch warning in acpi/boot.c Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1201385513-26885-6-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®