* [PATCH] x86: pit_clockevent can be static
@ 2008-02-12 20:10 Harvey Harrison
2008-02-13 10:40 ` Ingo Molnar
2008-02-16 18:29 ` Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Harvey Harrison @ 2008-02-12 20:10 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Thomas Gleixner, H. Peter Anvin, LKML
arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
arch/x86/kernel/i8253.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/i8253.c b/arch/x86/kernel/i8253.c
index ef62b07..8540abe 100644
--- a/arch/x86/kernel/i8253.c
+++ b/arch/x86/kernel/i8253.c
@@ -95,7 +95,7 @@ static int pit_next_event(unsigned long delta, struct clock_event_device *evt)
* registered. This mechanism replaces the previous #ifdef LOCAL_APIC -
* !using_apic_timer decisions in do_timer_interrupt_hook()
*/
-struct clock_event_device pit_clockevent = {
+static struct clock_event_device pit_clockevent = {
.name = "pit",
.features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
.set_mode = init_pit_timer,
--
1.5.4.1.1278.gc75be
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: pit_clockevent can be static
2008-02-12 20:10 [PATCH] x86: pit_clockevent can be static Harvey Harrison
@ 2008-02-13 10:40 ` Ingo Molnar
2008-02-16 18:29 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-02-13 10:40 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Thomas Gleixner, H. Peter Anvin, LKML
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was
> not declared. Should it be static?
yeah. Thanks Harvey, applied.
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: pit_clockevent can be static
2008-02-12 20:10 [PATCH] x86: pit_clockevent can be static Harvey Harrison
2008-02-13 10:40 ` Ingo Molnar
@ 2008-02-16 18:29 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2008-02-16 18:29 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, H. Peter Anvin, LKML
On Tue, 12 Feb 2008, Harvey Harrison wrote:
> arch/x86/kernel/i8253.c:98:27: warning: symbol 'pit_clockevent' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied. Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-16 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-12 20:10 [PATCH] x86: pit_clockevent can be static Harvey Harrison
2008-02-13 10:40 ` Ingo Molnar
2008-02-16 18:29 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome