mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Carlos Corbacho <carlos@strangeworlds.co.uk>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 17/27] acer-wmi: fix section mismatch warnings
Date: Sun, 17 Feb 2008 13:22:54 +0100	[thread overview]
Message-ID: <1203250984-11285-17-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080217121255.GA10519@uranus.ravnborg.org>

Fix following warnings:
WARNING: vmlinux.o(.text+0x672615): Section mismatch in reference from the function acer_platform_remove() to the function .exit.text:acer_backlight_exit()
WARNING: vmlinux.o(.devinit.text+0x1e859): Section mismatch in reference from the function acer_platform_probe() to the function .init.text:acer_led_init()
WARNING: vmlinux.o(.devinit.text+0x1e878): Section mismatch in reference from the function acer_platform_probe() to the function .init.text:acer_backlight_init()

Remove __exit annotation from acer_backlight_exit(). We cannot reference
a __exit annotated function from non __exit functions.

acer_led_init() and acer_backlight_init() where both annotated __init but
used from a __devinit function. This would result in an oops should
gcc drop their inlining and the module are hot plugged.

Fix by annotating acer_led_init() and acer_backlight_init() __devinit.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Len Brown <len.brown@intel.com>
---
 drivers/misc/acer-wmi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/acer-wmi.c b/drivers/misc/acer-wmi.c
index d7aea93..cdc733b 100644
--- a/drivers/misc/acer-wmi.c
+++ b/drivers/misc/acer-wmi.c
@@ -756,7 +756,7 @@ static struct led_classdev mail_led = {
 	.brightness_set = mail_led_set,
 };
 
-static int __init acer_led_init(struct device *dev)
+static int __devinit acer_led_init(struct device *dev)
 {
 	return led_classdev_register(dev, &mail_led);
 }
@@ -789,7 +789,7 @@ static struct backlight_ops acer_bl_ops = {
 	.update_status = update_bl_status,
 };
 
-static int __init acer_backlight_init(struct device *dev)
+static int __devinit acer_backlight_init(struct device *dev)
 {
 	struct backlight_device *bd;
 
@@ -808,7 +808,7 @@ static int __init acer_backlight_init(struct device *dev)
 	return 0;
 }
 
-static void __exit acer_backlight_exit(void)
+static void acer_backlight_exit(void)
 {
 	backlight_device_unregister(acer_backlight_device);
 }
-- 
1.5.4.rc3.14.g44397


  parent reply	other threads:[~2008-02-17 12:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 12:12 [PATCH 0/27] fix section mismatches Sam Ravnborg
2008-02-17 12:22 ` [PATCH 01/27] serial: silence section mismatch warnings in 8250_pci Sam Ravnborg
2008-02-17 12:22 ` [PATCH 02/27] rtc: silence section mismatch warning in rtc-test Sam Ravnborg
2008-02-17 12:22 ` [PATCH 03/27] pcmcia: silence section mismatch warnings from class_interface variables Sam Ravnborg
2008-02-17 12:22 ` [PATCH 04/27] pcmcia: silence section mismatch warnings from pci_driver variables Sam Ravnborg
2008-02-17 12:22 ` [PATCH 05/27] cpu: fix section mismatch warnings in hotcpu_register Sam Ravnborg
2008-02-17 12:22 ` [PATCH 06/27] cpu: fix section mismatch warning in unregister_cpu_notifier Sam Ravnborg
2008-02-17 12:22 ` [PATCH 07/27] cpu: fix section mismatch warnings in *cpu_down Sam Ravnborg
2008-02-17 12:22 ` [PATCH 08/27] cpu: fix section mismatch warning in reference to register_cpu_notifier Sam Ravnborg
2008-02-17 12:22 ` [PATCH 09/27] x86: fix section mismatch warning in setup_64.c:nearby_node Sam Ravnborg
2008-02-17 13:44   ` Thomas Gleixner
2008-02-17 15:05     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 10/27] x86: fix section mismatch in setup_64.c:srat_detect_node Sam Ravnborg
2008-02-17 12:22 ` [PATCH 11/27] acpi: fix section mismatch in processor_core.c:acpi_processor_hotplug_notify Sam Ravnborg
2008-02-17 12:22 ` [PATCH 12/27] x86: fix section mismatch warning in topology.c:arch_register_cpu Sam Ravnborg
2008-02-17 12:22 ` [PATCH 13/27] drivers/base/cpu: fix section mismatch in cpu.c:store_online Sam Ravnborg
2008-02-17 12:22 ` [PATCH 14/27] hwmon: fix section mismatch in coretemp Sam Ravnborg
2008-02-17 17:07   ` Mark M. Hoffman
2008-02-17 17:20     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 15/27] cpufreq: fix section mismatch warnings Sam Ravnborg
2008-02-17 12:22 ` [PATCH 16/27] scsi: fix section mismatch in aic94xx Sam Ravnborg
2008-02-17 12:22 ` Sam Ravnborg [this message]
2008-02-17 13:03   ` [PATCH 17/27] acer-wmi: fix section mismatch warnings Carlos Corbacho
2008-02-17 15:05     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 18/27] video: fix section mismatch warnings in uvesafb Sam Ravnborg
2008-02-17 12:22 ` [PATCH 19/27] tpm: fix section mismatch warning Sam Ravnborg
2008-02-17 12:22 ` [PATCH 20/27] [ALSA] caiaq - " Sam Ravnborg
2008-02-18 10:35   ` Takashi Iwai
2008-02-17 12:22 ` [PATCH 21/27] x86: fix section mismatch in srat_64.c:reserve_hotadd Sam Ravnborg
2008-02-17 12:22 ` [PATCH 22/27] x86: fix section mismatch in head_64.S:initial_code Sam Ravnborg
2008-02-17 12:23 ` [PATCH 23/27] x86: annotate pci/common.s:pci_scan_bus_with_sysdata with __devinit Sam Ravnborg
2008-02-17 12:23 ` [PATCH 24/27] pcmcia: annotate cb_alloc with __ref Sam Ravnborg
2008-02-17 12:23 ` [PATCH 25/27] pci: fix section mismatch warning in pci_scan_child_bus Sam Ravnborg
2008-02-17 12:23 ` [PATCH 26/27] acpi: fix section mismatch in acpi_pci_root_add Sam Ravnborg
2008-02-17 12:23 ` [PATCH 27/27] [ALSA] hdsp - fix section mismatch warnings Sam Ravnborg
2008-02-18  6:43   ` Takashi Iwai
2008-02-18  7:45     ` Sam Ravnborg
2008-02-18 10:36       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203250984-11285-17-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=carlos@strangeworlds.co.uk \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®