mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, Greg KH <greg@kroah.com>
Subject: [PATCH 25/27] pci: fix section mismatch warning in pci_scan_child_bus
Date: Sun, 17 Feb 2008 13:23:02 +0100	[thread overview]
Message-ID: <1203250984-11285-25-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20080217121255.GA10519@uranus.ravnborg.org>

Fix following warning:
WARNING: vmlinux.o(.text+0x47bdb1): Section mismatch in reference from the function pci_scan_child_bus() to the function .devinit.text:pcibios_fixup_bus()

We had plenty of functions that could be annotated __devinit but
due to the former restriction that annotated symbols could not
be annotated they were not so.
So annotate these function and fix the references from the
pci/hotplug/* code to silence the resuting warnings.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Greg KH <greg@kroah.com>
---
 drivers/pci/hotplug-pci.c              |    2 +-
 drivers/pci/hotplug/acpiphp_glue.c     |    2 +-
 drivers/pci/hotplug/cpci_hotplug_pci.c |    2 +-
 drivers/pci/hotplug/pciehp_pci.c       |    2 +-
 drivers/pci/hotplug/shpchp_pci.c       |    2 +-
 drivers/pci/probe.c                    |    8 ++++----
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/pci/hotplug-pci.c b/drivers/pci/hotplug-pci.c
index a590ef6..4d4a644 100644
--- a/drivers/pci/hotplug-pci.c
+++ b/drivers/pci/hotplug-pci.c
@@ -4,7 +4,7 @@
 #include "pci.h"
 
 
-unsigned int pci_do_scan_bus(struct pci_bus *bus)
+unsigned int __devinit pci_do_scan_bus(struct pci_bus *bus)
 {
 	unsigned int max;
 
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index cf22f9e..5e50008 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -1085,7 +1085,7 @@ static int acpiphp_bus_trim(acpi_handle handle)
  * This function should be called per *physical slot*,
  * not per each slot object in ACPI namespace.
  */
-static int enable_device(struct acpiphp_slot *slot)
+static int __ref enable_device(struct acpiphp_slot *slot)
 {
 	struct pci_dev *dev;
 	struct pci_bus *bus = slot->bridge->pci_bus;
diff --git a/drivers/pci/hotplug/cpci_hotplug_pci.c b/drivers/pci/hotplug/cpci_hotplug_pci.c
index 5e9be44..dddac96 100644
--- a/drivers/pci/hotplug/cpci_hotplug_pci.c
+++ b/drivers/pci/hotplug/cpci_hotplug_pci.c
@@ -250,7 +250,7 @@ int cpci_led_off(struct slot* slot)
  * Device configuration functions
  */
 
-int cpci_configure_slot(struct slot* slot)
+int __ref cpci_configure_slot(struct slot* slot)
 {
 	struct pci_bus *parent;
 	int fn;
diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c
index dd50713..9372a84 100644
--- a/drivers/pci/hotplug/pciehp_pci.c
+++ b/drivers/pci/hotplug/pciehp_pci.c
@@ -167,7 +167,7 @@ static void program_fw_provided_values(struct pci_dev *dev)
 	}
 }
 
-static int pciehp_add_bridge(struct pci_dev *dev)
+static int __ref pciehp_add_bridge(struct pci_dev *dev)
 {
 	struct pci_bus *parent = dev->bus;
 	int pass, busnr, start = parent->secondary;
diff --git a/drivers/pci/hotplug/shpchp_pci.c b/drivers/pci/hotplug/shpchp_pci.c
index 0a6b25e..a69a215 100644
--- a/drivers/pci/hotplug/shpchp_pci.c
+++ b/drivers/pci/hotplug/shpchp_pci.c
@@ -96,7 +96,7 @@ static void program_fw_provided_values(struct pci_dev *dev)
 	}
 }
 
-int shpchp_configure_device(struct slot *p_slot)
+int __ref shpchp_configure_device(struct slot *p_slot)
 {
 	struct pci_dev *dev;
 	struct pci_bus *parent = p_slot->ctrl->pci_dev->subordinate;
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 4d23b9f..5ffd610 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -286,7 +286,7 @@ static void pci_read_bases(struct pci_dev *dev, unsigned int howmany, int rom)
 	}
 }
 
-void pci_read_bridge_bases(struct pci_bus *child)
+void __devinit pci_read_bridge_bases(struct pci_bus *child)
 {
 	struct pci_dev *dev = child->self;
 	u8 io_base_lo, io_limit_lo;
@@ -472,7 +472,7 @@ static void pci_fixup_parent_subordinate_busnr(struct pci_bus *child, int max)
  * them, we proceed to assigning numbers to the remaining buses in
  * order to avoid overlaps between old and new bus numbers.
  */
-int pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max, int pass)
+int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max, int pass)
 {
 	struct pci_bus *child;
 	int is_cardbus = (dev->hdr_type == PCI_HEADER_TYPE_CARDBUS);
@@ -1008,7 +1008,7 @@ int pci_scan_slot(struct pci_bus *bus, int devfn)
 	return nr;
 }
 
-unsigned int pci_scan_child_bus(struct pci_bus *bus)
+unsigned int __devinit pci_scan_child_bus(struct pci_bus *bus)
 {
 	unsigned int devfn, pass, max = bus->secondary;
 	struct pci_dev *dev;
@@ -1116,7 +1116,7 @@ err_out:
 	return NULL;
 }
 
-struct pci_bus *pci_scan_bus_parented(struct device *parent,
+struct pci_bus * __devinit pci_scan_bus_parented(struct device *parent,
 		int bus, struct pci_ops *ops, void *sysdata)
 {
 	struct pci_bus *b;
-- 
1.5.4.rc3.14.g44397


  parent reply	other threads:[~2008-02-17 12:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-17 12:12 [PATCH 0/27] fix section mismatches Sam Ravnborg
2008-02-17 12:22 ` [PATCH 01/27] serial: silence section mismatch warnings in 8250_pci Sam Ravnborg
2008-02-17 12:22 ` [PATCH 02/27] rtc: silence section mismatch warning in rtc-test Sam Ravnborg
2008-02-17 12:22 ` [PATCH 03/27] pcmcia: silence section mismatch warnings from class_interface variables Sam Ravnborg
2008-02-17 12:22 ` [PATCH 04/27] pcmcia: silence section mismatch warnings from pci_driver variables Sam Ravnborg
2008-02-17 12:22 ` [PATCH 05/27] cpu: fix section mismatch warnings in hotcpu_register Sam Ravnborg
2008-02-17 12:22 ` [PATCH 06/27] cpu: fix section mismatch warning in unregister_cpu_notifier Sam Ravnborg
2008-02-17 12:22 ` [PATCH 07/27] cpu: fix section mismatch warnings in *cpu_down Sam Ravnborg
2008-02-17 12:22 ` [PATCH 08/27] cpu: fix section mismatch warning in reference to register_cpu_notifier Sam Ravnborg
2008-02-17 12:22 ` [PATCH 09/27] x86: fix section mismatch warning in setup_64.c:nearby_node Sam Ravnborg
2008-02-17 13:44   ` Thomas Gleixner
2008-02-17 15:05     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 10/27] x86: fix section mismatch in setup_64.c:srat_detect_node Sam Ravnborg
2008-02-17 12:22 ` [PATCH 11/27] acpi: fix section mismatch in processor_core.c:acpi_processor_hotplug_notify Sam Ravnborg
2008-02-17 12:22 ` [PATCH 12/27] x86: fix section mismatch warning in topology.c:arch_register_cpu Sam Ravnborg
2008-02-17 12:22 ` [PATCH 13/27] drivers/base/cpu: fix section mismatch in cpu.c:store_online Sam Ravnborg
2008-02-17 12:22 ` [PATCH 14/27] hwmon: fix section mismatch in coretemp Sam Ravnborg
2008-02-17 17:07   ` Mark M. Hoffman
2008-02-17 17:20     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 15/27] cpufreq: fix section mismatch warnings Sam Ravnborg
2008-02-17 12:22 ` [PATCH 16/27] scsi: fix section mismatch in aic94xx Sam Ravnborg
2008-02-17 12:22 ` [PATCH 17/27] acer-wmi: fix section mismatch warnings Sam Ravnborg
2008-02-17 13:03   ` Carlos Corbacho
2008-02-17 15:05     ` Sam Ravnborg
2008-02-17 12:22 ` [PATCH 18/27] video: fix section mismatch warnings in uvesafb Sam Ravnborg
2008-02-17 12:22 ` [PATCH 19/27] tpm: fix section mismatch warning Sam Ravnborg
2008-02-17 12:22 ` [PATCH 20/27] [ALSA] caiaq - " Sam Ravnborg
2008-02-18 10:35   ` Takashi Iwai
2008-02-17 12:22 ` [PATCH 21/27] x86: fix section mismatch in srat_64.c:reserve_hotadd Sam Ravnborg
2008-02-17 12:22 ` [PATCH 22/27] x86: fix section mismatch in head_64.S:initial_code Sam Ravnborg
2008-02-17 12:23 ` [PATCH 23/27] x86: annotate pci/common.s:pci_scan_bus_with_sysdata with __devinit Sam Ravnborg
2008-02-17 12:23 ` [PATCH 24/27] pcmcia: annotate cb_alloc with __ref Sam Ravnborg
2008-02-17 12:23 ` Sam Ravnborg [this message]
2008-02-17 12:23 ` [PATCH 26/27] acpi: fix section mismatch in acpi_pci_root_add Sam Ravnborg
2008-02-17 12:23 ` [PATCH 27/27] [ALSA] hdsp - fix section mismatch warnings Sam Ravnborg
2008-02-18  6:43   ` Takashi Iwai
2008-02-18  7:45     ` Sam Ravnborg
2008-02-18 10:36       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203250984-11285-25-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®