From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, andrew.grover@intel.com,
paul.s.diefenbaugh@intel.com, linux@brodo.de,
anil.s.keshavamurthy@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, Glauber Costa <gcosta@redhat.com>
Subject: [PATCH 1/4] make cdev attribuition the last step
Date: Mon, 18 Feb 2008 17:56:50 -0300 [thread overview]
Message-ID: <1203368213-30528-1-git-send-email-gcosta@redhat.com> (raw)
This patch uses a temporary variable "cdev" instead of using
directly pr->cdev. Through it, we can tell later whether or not
this code was completed properly: by checking for pr->cdev != NULL
Signed-off-by: Glauber Costa <gcosta@redhat.com>
---
drivers/acpi/processor_core.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 75ccf5d..9480203 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -622,7 +622,7 @@ static int __cpuinit acpi_processor_star
int result = 0;
acpi_status status = AE_OK;
struct acpi_processor *pr;
-
+ struct thermal_cooling_device *cdev;
pr = acpi_driver_data(device);
@@ -668,24 +668,26 @@ #endif
acpi_processor_power_init(pr, device);
- pr->cdev = thermal_cooling_device_register("Processor", device,
+ cdev = thermal_cooling_device_register("Processor", device,
&processor_cooling_ops);
- if (pr->cdev)
+ if (cdev)
printk(KERN_INFO PREFIX
"%s is registered as cooling_device%d\n",
- device->dev.bus_id, pr->cdev->id);
+ device->dev.bus_id, cdev->id);
else
goto end;
- result = sysfs_create_link(&device->dev.kobj, &pr->cdev->device.kobj,
+ result = sysfs_create_link(&device->dev.kobj, &cdev->device.kobj,
"thermal_cooling");
if (result)
return result;
- result = sysfs_create_link(&pr->cdev->device.kobj, &device->dev.kobj,
+ result = sysfs_create_link(&cdev->device.kobj, &device->dev.kobj,
"device");
if (result)
return result;
+ pr->cdev = cdev;
+
if (pr->flags.throttling) {
printk(KERN_INFO PREFIX "%s [%s] (supports",
acpi_device_name(device), acpi_device_bid(device));
--
1.4.2
next reply other threads:[~2008-02-18 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 20:56 Glauber Costa [this message]
2008-02-18 20:56 ` [PATCH 2/4] use pr->cdev as a condition for cleanup Glauber Costa
2008-02-18 20:56 ` [PATCH 3/4] provide error handling for unclean objects Glauber Costa
2008-02-18 20:56 ` [PATCH 4/4] remove goto statement Glauber Costa
2008-02-19 1:19 ` Li Zefan
2008-02-19 2:07 ` Glauber Costa
2008-02-19 2:22 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203368213-30528-1-git-send-email-gcosta@redhat.com \
--to=gcosta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.grover@intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=paul.s.diefenbaugh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®