mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glauber Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, andrew.grover@intel.com,
	paul.s.diefenbaugh@intel.com, linux@brodo.de,
	anil.s.keshavamurthy@intel.com, lenb@kernel.org,
	linux-acpi@vger.kernel.org
Subject: [PATCH 4/4] remove goto statement
Date: Mon, 18 Feb 2008 17:56:53 -0300	[thread overview]
Message-ID: <1203368213-30528-4-git-send-email-gcosta@redhat.com> (raw)
In-Reply-To: <1203368213-30528-3-git-send-email-gcosta@redhat.com>

This patch removes goto statements in favour of plain returns
in places that had nothing left behind that would justify
such construction
---
 drivers/acpi/processor_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 06a230a..70f62b6 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -651,7 +651,7 @@ static int __cpuinit acpi_processor_star
 
 	result = acpi_processor_add_fs(device);
 	if (result)
-		goto end;
+		return result;
 
 	status = acpi_install_notify_handler(pr->handle, ACPI_DEVICE_NOTIFY,
 					     acpi_processor_notify, pr);
@@ -675,7 +675,7 @@ #endif
 			"%s is registered as cooling_device%d\n",
 			device->dev.bus_id, cdev->id);
 	else
-		goto end;
+		return result;
 
 	result = sysfs_create_link(&device->dev.kobj, &cdev->device.kobj,
 					"thermal_cooling");
-- 
1.4.2


  reply	other threads:[~2008-02-18 21:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 20:56 [PATCH 1/4] make cdev attribuition the last step Glauber Costa
2008-02-18 20:56 ` [PATCH 2/4] use pr->cdev as a condition for cleanup Glauber Costa
2008-02-18 20:56   ` [PATCH 3/4] provide error handling for unclean objects Glauber Costa
2008-02-18 20:56     ` Glauber Costa [this message]
2008-02-19  1:19       ` [PATCH 4/4] remove goto statement Li Zefan
2008-02-19  2:07         ` Glauber Costa
2008-02-19  2:22           ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203368213-30528-4-git-send-email-gcosta@redhat.com \
    --to=gcosta@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.grover@intel.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=paul.s.diefenbaugh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®