mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Joerg Roedel" <joerg.roedel@amd.com>
To: tglx@linutronix.de, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, "Joerg Roedel" <joerg.roedel@amd.com>
Subject: [PATCH] X86: remove WARN_ON if MTRRs are all blank
Date: Thu, 21 Feb 2008 12:32:38 +0100	[thread overview]
Message-ID: <1203593558-3391-1-git-send-email-joerg.roedel@amd.com> (raw)

When running Linux inside KVM all MTRRs are blank because there is no reason to
set them up. So doing a WARN_ON if all MTRRs are blank is not necessary. It is
sufficient to print the warning message using printk.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/cpu/mtrr/main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
index b6e136f..e7f95a9 100644
--- a/arch/x86/kernel/cpu/mtrr/main.c
+++ b/arch/x86/kernel/cpu/mtrr/main.c
@@ -689,7 +689,6 @@ int __init mtrr_trim_uncached_memory(unsigned long end_pfn)
 	/* kvm/qemu doesn't have mtrr set right, don't trim them all */
 	if (!highest_pfn) {
 		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
-		WARN_ON(1);
 		return 0;
 	}
 
-- 
1.5.3.7




             reply	other threads:[~2008-02-21 11:33 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 11:32 Joerg Roedel [this message]
2008-02-21 11:54 ` Ingo Molnar
2008-02-21 12:47   ` Joerg Roedel
2008-02-21 13:03     ` Ingo Molnar
2008-02-21 13:27       ` Joerg Roedel
2008-09-07 23:45   ` [PATCH 1/2] VMware detection support for x86 and x86-64 Yan Li
2008-09-08  0:36     ` David Dillow
2008-09-08  1:49       ` Yan Li
2008-09-08 14:04     ` Ingo Molnar
2008-09-09  0:20       ` Yan Li
2008-09-09  0:34         ` H. Peter Anvin
2008-09-09 12:28           ` Yan Li
2008-09-09 20:12             ` H. Peter Anvin
2008-09-16 13:32           ` Yan Li
2008-09-17 10:52             ` Ingo Molnar
2008-09-17 14:03               ` Yan Li
2008-09-17 14:10                 ` Ingo Molnar
2008-09-17 15:38                   ` H. Peter Anvin
2008-09-24 12:22                     ` [PATCH 1/2] VMware guest detection " Yan Li
2008-09-24 14:10                       ` Cristi Magherusan
2008-09-24 14:23                         ` Yan Li
2008-09-24 16:19                           ` Alok kataria
2008-09-24 16:21                             ` H. Peter Anvin
2008-09-25  0:19                               ` Yan Li
2008-09-25  0:15                             ` Yan Li
2008-09-25  0:26                               ` H. Peter Anvin
2008-09-25  2:34                                 ` Yan Li
2008-09-24 18:13                           ` Cristi Magherusan
2008-09-24 18:16                             ` H. Peter Anvin
2008-09-25  0:23                             ` Yan Li
2008-09-25  1:28                               ` Bernd Eckenfels
2008-09-24 16:19                       ` H. Peter Anvin
2008-09-25  0:32                         ` Yan Li
2008-09-25  0:37                           ` H. Peter Anvin
2008-09-25  2:48                             ` Yan Li
2008-09-25  9:56                           ` David Sanders
2008-09-25 10:23                             ` Yan Li
2008-09-25  2:23                       ` Greg KH
2008-09-25  2:47                         ` Yan Li
2008-09-25  2:55                           ` Greg KH
2008-09-25  3:29                             ` Yan Li
2008-09-25  4:54                             ` H. Peter Anvin
2008-09-25 12:56                               ` Greg KH
2008-09-25 14:38                               ` Yan Li
2008-09-25  2:28       ` [PATCH 1/2] VMware detection support " Alok kataria
2008-09-25  4:38         ` H. Peter Anvin
2008-09-25  4:46           ` Alok Kataria
2008-09-25  4:54             ` H. Peter Anvin
2008-09-25  5:02               ` Alok Kataria
2008-09-25  5:04                 ` H. Peter Anvin
2008-09-25  5:23                   ` Alok Kataria
2008-09-25  5:30                     ` H. Peter Anvin
2008-09-25  8:45                     ` Alan Cox
2008-09-25 20:48                     ` Zachary Amsden
2008-09-25 21:59                       ` H. Peter Anvin
2008-09-25 22:20                         ` Zachary Amsden
2008-09-25 22:27                           ` H. Peter Anvin
2008-09-26 12:27                             ` Valdis.Kletnieks
2008-09-26 12:47                             ` Gerd Hoffmann
2008-09-26 13:22                               ` Valdis.Kletnieks
2008-09-26 17:37                                 ` H. Peter Anvin
2008-10-03 14:12                                   ` Pavel Machek
2008-09-26 20:35                                 ` Zachary Amsden
2008-09-25 22:17                       ` David Sanders
2008-09-07 23:47   ` [PATCH 2/2] avoid mtrr warning message when running as VMware guest Yan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203593558-3391-1-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®