From: Yan Li <elliot.li.tech@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yan Li <elliot.li.tech@gmail.com>,
Alok kataria <alokkataria1@gmail.com>,
Cristi Magherusan <cristi.magherusan@net.utcluj.ro>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
joerg.roedel@amd.com, rjmaomao@gmail.com,
Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
nancydreaming@gmail.com, akataria@vmware.com,
Zachary Amsden <zach@vmware.com>,
Daniel Hecht <dhecht@vmware.com>
Subject: Re: [PATCH 1/2] VMware guest detection for x86 and x86-64
Date: Thu, 25 Sep 2008 10:34:16 +0800 [thread overview]
Message-ID: <20080925023415.GF21049@yantp.cn.ibm.com> (raw)
In-Reply-To: <48DADAC6.2080500@zytor.com>
On Wed, Sep 24, 2008 at 05:26:46PM -0700, H. Peter Anvin wrote:
> Yan Li wrote:
>> My motivation behind this patch is to serve the MTRR codes to fix a
>> false warning,
>
> It's not a false warning. It's a true warning.
You can say that warning is justified because it's true that the
MTRR's are all blank in VMware. But that warning is no good to VMware
users since it's by-design all MTRR's are blank. For example, we've
scripts watching the log for lines containing "warning" and "error" on
all production servers. So this warning actually is "false" to VMware
guest users. A KERN_INFO message should be enough here.
We already have a checking to suppress warning on KVM so I think we
should also suppress the warning for VMware guest and Virtual PC.
--
Li, Yan
next prev parent reply other threads:[~2008-09-25 2:34 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 11:32 [PATCH] X86: remove WARN_ON if MTRRs are all blank Joerg Roedel
2008-02-21 11:54 ` Ingo Molnar
2008-02-21 12:47 ` Joerg Roedel
2008-02-21 13:03 ` Ingo Molnar
2008-02-21 13:27 ` Joerg Roedel
2008-09-07 23:45 ` [PATCH 1/2] VMware detection support for x86 and x86-64 Yan Li
2008-09-08 0:36 ` David Dillow
2008-09-08 1:49 ` Yan Li
2008-09-08 14:04 ` Ingo Molnar
2008-09-09 0:20 ` Yan Li
2008-09-09 0:34 ` H. Peter Anvin
2008-09-09 12:28 ` Yan Li
2008-09-09 20:12 ` H. Peter Anvin
2008-09-16 13:32 ` Yan Li
2008-09-17 10:52 ` Ingo Molnar
2008-09-17 14:03 ` Yan Li
2008-09-17 14:10 ` Ingo Molnar
2008-09-17 15:38 ` H. Peter Anvin
2008-09-24 12:22 ` [PATCH 1/2] VMware guest detection " Yan Li
2008-09-24 14:10 ` Cristi Magherusan
2008-09-24 14:23 ` Yan Li
2008-09-24 16:19 ` Alok kataria
2008-09-24 16:21 ` H. Peter Anvin
2008-09-25 0:19 ` Yan Li
2008-09-25 0:15 ` Yan Li
2008-09-25 0:26 ` H. Peter Anvin
2008-09-25 2:34 ` Yan Li [this message]
2008-09-24 18:13 ` Cristi Magherusan
2008-09-24 18:16 ` H. Peter Anvin
2008-09-25 0:23 ` Yan Li
2008-09-25 1:28 ` Bernd Eckenfels
2008-09-24 16:19 ` H. Peter Anvin
2008-09-25 0:32 ` Yan Li
2008-09-25 0:37 ` H. Peter Anvin
2008-09-25 2:48 ` Yan Li
2008-09-25 9:56 ` David Sanders
2008-09-25 10:23 ` Yan Li
2008-09-25 2:23 ` Greg KH
2008-09-25 2:47 ` Yan Li
2008-09-25 2:55 ` Greg KH
2008-09-25 3:29 ` Yan Li
2008-09-25 4:54 ` H. Peter Anvin
2008-09-25 12:56 ` Greg KH
2008-09-25 14:38 ` Yan Li
2008-09-25 2:28 ` [PATCH 1/2] VMware detection support " Alok kataria
2008-09-25 4:38 ` H. Peter Anvin
2008-09-25 4:46 ` Alok Kataria
2008-09-25 4:54 ` H. Peter Anvin
2008-09-25 5:02 ` Alok Kataria
2008-09-25 5:04 ` H. Peter Anvin
2008-09-25 5:23 ` Alok Kataria
2008-09-25 5:30 ` H. Peter Anvin
2008-09-25 8:45 ` Alan Cox
2008-09-25 20:48 ` Zachary Amsden
2008-09-25 21:59 ` H. Peter Anvin
2008-09-25 22:20 ` Zachary Amsden
2008-09-25 22:27 ` H. Peter Anvin
2008-09-26 12:27 ` Valdis.Kletnieks
2008-09-26 12:47 ` Gerd Hoffmann
2008-09-26 13:22 ` Valdis.Kletnieks
2008-09-26 17:37 ` H. Peter Anvin
2008-10-03 14:12 ` Pavel Machek
2008-09-26 20:35 ` Zachary Amsden
2008-09-25 22:17 ` David Sanders
2008-09-07 23:47 ` [PATCH 2/2] avoid mtrr warning message when running as VMware guest Yan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925023415.GF21049@yantp.cn.ibm.com \
--to=elliot.li.tech@gmail.com \
--cc=akataria@vmware.com \
--cc=alokkataria1@gmail.com \
--cc=cristi.magherusan@net.utcluj.ro \
--cc=dhecht@vmware.com \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nancydreaming@gmail.com \
--cc=rjmaomao@gmail.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®