mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SCSI_AIC94XX must depend on SCSI
Date: Thu, 06 Mar 2008 14:31:07 -0600	[thread overview]
Message-ID: <1204835467.3062.42.camel@localhost.localdomain> (raw)
In-Reply-To: <20080306202246.GB5259@cs181133002.pp.htv.fi>

On Thu, 2008-03-06 at 22:22 +0200, Adrian Bunk wrote:
> This patch fixes the following build error reported by Toralf Förster:
> 
> <--  snip  -->
> 
> ...
>   MODPOST 243 modules
> ERROR: "sas_bios_param" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_change_queue_type" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_change_queue_depth" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_target_destroy" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_target_alloc" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_destroy" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_configure" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_eh_bus_reset_handler" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_eh_device_reset_handler" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_queuecommand" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_ioctl" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_register_ha" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_domain_attach_transport" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_ssp_task_response" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_alloc" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_unregister_ha" [drivers/scsi/mvsas.ko] undefined!
> make[1]: *** [__modpost] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> --- a/drivers/scsi/aic94xx/Kconfig
> +++ b/drivers/scsi/aic94xx/Kconfig
> @@ -26,7 +26,7 @@
>  
>  config SCSI_AIC94XX
>  	tristate "Adaptec AIC94xx SAS/SATA support"
> -	depends on PCI
> +	depends on SCSI && PCI
>  	select SCSI_SAS_LIBSAS
>  	select FW_LOADER

This doesn't look to be a fix for your error: the symbols you've listed
as missing are all libsas ones, not core SCSI ones.  Also they're all
claiming to be missing from mvsas, not aic94xx.  There's something else
about the configuration that produced this error.

James



  reply	other threads:[~2008-03-06 20:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 19:09 build #407 issue for v2.6.25-rc4-56-gd7fe321 : "sas_bios_param" [drivers/scsi/mvsas.ko] undefined! Toralf Förster
2008-03-06 20:22 ` [2.6 patch] SCSI_AIC94XX must depend on SCSI Adrian Bunk
2008-03-06 20:31   ` James Bottomley [this message]
2008-03-06 21:39     ` Adrian Bunk
2008-03-06 22:07       ` James Bottomley
2008-03-06 20:35   ` Darrick J. Wong
2008-03-06 21:32     ` James Bottomley
2008-03-06 22:30       ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204835467.3062.42.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®