From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: "Toralf Förster" <toralf.foerster@gmx.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] SCSI_AIC94XX must depend on SCSI
Date: Thu, 06 Mar 2008 16:07:42 -0600 [thread overview]
Message-ID: <1204841262.3062.60.camel@localhost.localdomain> (raw)
In-Reply-To: <20080306213938.GA1574@cs181133002.pp.htv.fi>
On Thu, 2008-03-06 at 23:39 +0200, Adrian Bunk wrote:
> This is the right fix for this bug.
Incidentally, just for future reference, this:
> We have:
> - SCSI=m
> - SCSI_AIC94XX=y
> - SCSI_MVSAS=m
> - SCSI_SAS_LIBSAS=y
>
> The problem is:
> - SCSI_AIC94XX selects (and requires) SCSI_SAS_LIBSAS
> - SCSI_MVSAS selects (and requires) SCSI_SAS_LIBSAS
> - with SCSI=m a SCSI_SAS_LIBSAS=y is not linked into the kernel
>
> SCSI_AIC94XX=y also results in the AIC94xx driver not being linked into
> the kernel here (and that's also fixed by this patch), but this alone
> wouldn't result in a build bug...
Is the right changelog for your fix (even if it got superceded), rather
than a compile dump that doesn't even mention the driver you're
patching.
James
next prev parent reply other threads:[~2008-03-06 22:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 19:09 build #407 issue for v2.6.25-rc4-56-gd7fe321 : "sas_bios_param" [drivers/scsi/mvsas.ko] undefined! Toralf Förster
2008-03-06 20:22 ` [2.6 patch] SCSI_AIC94XX must depend on SCSI Adrian Bunk
2008-03-06 20:31 ` James Bottomley
2008-03-06 21:39 ` Adrian Bunk
2008-03-06 22:07 ` James Bottomley [this message]
2008-03-06 20:35 ` Darrick J. Wong
2008-03-06 21:32 ` James Bottomley
2008-03-06 22:30 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204841262.3062.60.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®