From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] fs/binfmt_aout.c: Use printk_ratelimit()
Date: Mon, 17 Mar 2008 11:36:32 +0200 [thread overview]
Message-ID: <1205746593-24820-10-git-send-email-caglar@pardus.org.tr> (raw)
In-Reply-To: <1205746593-24820-9-git-send-email-caglar@pardus.org.tr>
Use printk_ratelimit() instead of jiffies based arithmetic, suggested by Geert Uytterhoeven
Cc: linux-arch@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>
---
fs/binfmt_aout.c | 12 +++---------
1 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c
index a1bb224..ba4cddb 100644
--- a/fs/binfmt_aout.c
+++ b/fs/binfmt_aout.c
@@ -372,21 +372,17 @@ static int load_aout_binary(struct linux_binprm * bprm, struct pt_regs * regs)
flush_icache_range(text_addr, text_addr+ex.a_text+ex.a_data);
} else {
- static unsigned long error_time, error_time2;
if ((ex.a_text & 0xfff || ex.a_data & 0xfff) &&
- (N_MAGIC(ex) != NMAGIC) && (jiffies-error_time2) > 5*HZ)
+ (N_MAGIC(ex) != NMAGIC) && printk_ratelimit())
{
printk(KERN_NOTICE "executable not page aligned\n");
- error_time2 = jiffies;
}
- if ((fd_offset & ~PAGE_MASK) != 0 &&
- (jiffies-error_time) > 5*HZ)
+ if ((fd_offset & ~PAGE_MASK) != 0 && printk_ratelimit())
{
printk(KERN_WARNING
"fd_offset is not page aligned. Please convert program: %s\n",
bprm->file->f_path.dentry->d_name.name);
- error_time = jiffies;
}
if (!bprm->file->f_op->mmap||((fd_offset & ~PAGE_MASK) != 0)) {
@@ -495,15 +491,13 @@ static int load_aout_library(struct file *file)
start_addr = ex.a_entry & 0xfffff000;
if ((N_TXTOFF(ex) & ~PAGE_MASK) != 0) {
- static unsigned long error_time;
loff_t pos = N_TXTOFF(ex);
- if ((jiffies-error_time) > 5*HZ)
+ if (printk_ratelimit())
{
printk(KERN_WARNING
"N_TXTOFF is not page aligned. Please convert library: %s\n",
file->f_path.dentry->d_name.name);
- error_time = jiffies;
}
down_write(¤t->mm->mmap_sem);
do_brk(start_addr, ex.a_text + ex.a_data + ex.a_bss);
--
1.5.4.3
next prev parent reply other threads:[~2008-03-17 9:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 9:36 [PATCH] arch/alpha/kernel/traps.c: Use time_* macros S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/ia64/kernel/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/parisc/kernel/unaligned.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/arcnet/arcnet.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/ax88796.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] net/mac80211/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/tokenring/3c359.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/wireless/atmel.c: " S.Çağlar Onur
2008-03-17 9:36 ` S.Çağlar Onur [this message]
2008-03-17 9:36 ` [PATCH] Fix indentation S.Çağlar Onur
2008-03-25 18:32 ` [PATCH] net/mac80211/: Use time_* macros John W. Linville
2008-03-17 23:31 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: " Stephen Rothwell
2008-03-17 15:40 ` [PATCH] arch/parisc/kernel/unaligned.c: " Kyle McMartin
2008-03-17 9:59 ` [PATCH] arch/ia64/kernel/: " KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205746593-24820-10-git-send-email-caglar@pardus.org.tr \
--to=caglar@pardus.org.tr \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome