From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: linux-kernel@vger.kernel.org
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* macros
Date: Mon, 17 Mar 2008 11:36:26 +0200 [thread overview]
Message-ID: <1205746593-24820-4-git-send-email-caglar@pardus.org.tr> (raw)
In-Reply-To: <1205746593-24820-3-git-send-email-caglar@pardus.org.tr>
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values.
So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly
Cc: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>
---
arch/powerpc/platforms/iseries/pci.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/iseries/pci.c b/arch/powerpc/platforms/iseries/pci.c
index cc562e4..02a634f 100644
--- a/arch/powerpc/platforms/iseries/pci.c
+++ b/arch/powerpc/platforms/iseries/pci.c
@@ -23,6 +23,7 @@
#undef DEBUG
+#include <linux/jiffies.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/string.h>
@@ -586,7 +587,7 @@ static inline struct device_node *xlate_iomm_address(
static unsigned long last_jiffies;
static int num_printed;
- if ((jiffies - last_jiffies) > 60 * HZ) {
+ if (time_after(jiffies, last_jiffies + 60 * HZ)) {
last_jiffies = jiffies;
num_printed = 0;
}
--
1.5.4.3
next prev parent reply other threads:[~2008-03-17 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 9:36 [PATCH] arch/alpha/kernel/traps.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/ia64/kernel/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] arch/parisc/kernel/unaligned.c: " S.Çağlar Onur
2008-03-17 9:36 ` S.Çağlar Onur [this message]
2008-03-17 9:36 ` [PATCH] drivers/net/arcnet/arcnet.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/ax88796.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] net/mac80211/: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/tokenring/3c359.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] drivers/net/wireless/atmel.c: " S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] fs/binfmt_aout.c: Use printk_ratelimit() S.Çağlar Onur
2008-03-17 9:36 ` [PATCH] Fix indentation S.Çağlar Onur
2008-03-25 18:32 ` [PATCH] net/mac80211/: Use time_* macros John W. Linville
2008-03-17 23:31 ` [PATCH] arch/powerpc/platforms/iseries/pci.c: " Stephen Rothwell
2008-03-17 15:40 ` [PATCH] arch/parisc/kernel/unaligned.c: " Kyle McMartin
2008-03-17 9:59 ` [PATCH] arch/ia64/kernel/: " KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205746593-24820-4-git-send-email-caglar@pardus.org.tr \
--to=caglar@pardus.org.tr \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome